Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2218903003: Revert of Disable crashy KioskTest.PRE_LaunchAppNetworkDown. (Closed)

Created:
4 years, 4 months ago by Xianzhu
Modified:
4 years, 4 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable crashy KioskTest.PRE_LaunchAppNetworkDown. (patchset #1 id:1 of https://codereview.chromium.org/2217983002/ ) Reason for revert: https://codereview.chromium.org/2212223004/ fixed the issue. Original issue's description: > Disable crashy KioskTest.PRE_LaunchAppNetworkDown. > > BUG=634807 > TBR=xiyuan@chromium.org > > Committed: https://crrev.com/739eacccde272d844e8e2cfd19952b3daf3b52b3 > Cr-Commit-Position: refs/heads/master@{#410026} TBR=xiyuan@chromium.org,grt@chromium.org BUG=634807 Committed: https://crrev.com/d90908aa349ab85861643550dcbe3863d1b219b5 Cr-Commit-Position: refs/heads/master@{#410251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Xianzhu
Created Revert of Disable crashy KioskTest.PRE_LaunchAppNetworkDown.
4 years, 4 months ago (2016-08-06 01:30:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218903003/1
4 years, 4 months ago (2016-08-06 01:30:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-06 02:01:21 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d90908aa349ab85861643550dcbe3863d1b219b5 Cr-Commit-Position: refs/heads/master@{#410251}
4 years, 4 months ago (2016-08-06 02:03:37 UTC) #8
grt (UTC plus 2)
4 years, 4 months ago (2016-08-07 10:03:06 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698