Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2218903002: Remove unused private functions from Encryptor (Closed)

Created:
4 years, 4 months ago by kuznetsovs
Modified:
4 years, 4 months ago
Reviewers:
agl, davidben, Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused private functions from Encryptor GenerateCounterMask, MaskMessage were used in nss implementation. R=agl@chromium.org,davidben@chromium.org,rsleevi@chromium.org BUG= Committed: https://crrev.com/45c722a2dbd46ae398bf1fa65bdea444a8ce1aea Cr-Commit-Position: refs/heads/master@{#410051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -60 lines) Patch
M crypto/encryptor.h View 1 chunk +0 lines, -23 lines 0 comments Download
M crypto/encryptor.cc View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kuznetsovs
4 years, 4 months ago (2016-08-05 10:15:07 UTC) #1
davidben
lgtm
4 years, 4 months ago (2016-08-05 12:49:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218903002/1
4 years, 4 months ago (2016-08-05 12:51:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 13:53:57 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 13:55:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45c722a2dbd46ae398bf1fa65bdea444a8ce1aea
Cr-Commit-Position: refs/heads/master@{#410051}

Powered by Google App Engine
This is Rietveld 408576698