Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2218883002: Record HTMLPluginElement::requestObject result. (Closed)

Created:
2 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
2 years, 8 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record HTMLPluginElement::requestObject result. BUG=625984 Committed: https://crrev.com/c91b13c8b1e3eb18efc1e9de4ec67fbb2e678e91 Cr-Commit-Position: refs/heads/master@{#410794}

Patch Set 1 #

Patch Set 2 : clean ups #

Total comments: 2

Patch Set 3 : pdr comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -18 lines) Patch
M third_party/WebKit/Source/core/html/HTMLPlugInElement.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 2 4 chunks +42 lines, -18 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (18 generated)
mlamouri (slow - plz ping)
I hope you guys like goto :)
2 years, 8 months ago (2016-08-05 10:24:14 UTC) #3
mlamouri (slow - plz ping)
-mkwst@ (he is OOO) +foolip@ +asvtikine@ because isherman@ is OOO today
2 years, 8 months ago (2016-08-05 14:35:45 UTC) #8
mlamouri (slow - plz ping)
2 years, 8 months ago (2016-08-05 14:37:59 UTC) #10
Alexei Svitkine (slow)
lgtm
2 years, 8 months ago (2016-08-05 14:38:18 UTC) #13
mlamouri (slow - plz ping)
+foolip@ for real...
2 years, 8 months ago (2016-08-09 11:08:14 UTC) #16
foolip
I am sheriff today and tomorrow, can you find another reviewer?
2 years, 8 months ago (2016-08-09 12:48:54 UTC) #17
mlamouri (slow - plz ping)
pdr@, can you PTAL? :)
2 years, 8 months ago (2016-08-09 17:27:42 UTC) #19
pdr.
https://codereview.chromium.org/2218883002/diff/20001/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp File third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp (right): https://codereview.chromium.org/2218883002/diff/20001/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp#newcode460 third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp:460: bool HTMLPlugInElement::requestObject(const String& url, const String& mimeType, const Vector<String>& ...
2 years, 8 months ago (2016-08-09 17:45:46 UTC) #20
mlamouri (slow - plz ping)
PTAL https://codereview.chromium.org/2218883002/diff/20001/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp File third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp (right): https://codereview.chromium.org/2218883002/diff/20001/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp#newcode460 third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp:460: bool HTMLPlugInElement::requestObject(const String& url, const String& mimeType, const ...
2 years, 8 months ago (2016-08-09 18:20:21 UTC) #21
pdr.
Thanks, LGTM
2 years, 8 months ago (2016-08-09 18:24:50 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218883002/40001
2 years, 8 months ago (2016-08-09 18:33:06 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
2 years, 8 months ago (2016-08-09 20:25:11 UTC) #29
commit-bot: I haz the power
2 years, 8 months ago (2016-08-09 20:28:15 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c91b13c8b1e3eb18efc1e9de4ec67fbb2e678e91
Cr-Commit-Position: refs/heads/master@{#410794}

Powered by Google App Engine
This is Rietveld 408576698