Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2218863002: Implement '[SecureContext]' IDL attribute for partial interfaces. (Closed)

Created:
4 years, 4 months ago by Mike West
Modified:
4 years, 4 months ago
Reviewers:
haraken, bashi, Yuki
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@secure1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement '[SecureContext]' IDL attribute for partial interfaces. Step 2 of implementing '[SecureContext]'. Step 1 was https://codereview.chromium.org/2207423002. BUG=634270 Committed: https://crrev.com/795763cbbdf49f52dc0879f3405575bded157623 Cr-Commit-Position: refs/heads/master@{#410037}

Patch Set 1 #

Patch Set 2 : This might work? #

Messages

Total messages: 17 (11 generated)
Mike West
Since you reviewed the initial patch, would y'all mind taking a look at this followup ...
4 years, 4 months ago (2016-08-05 10:19:50 UTC) #8
Yuki
LGTM.
4 years, 4 months ago (2016-08-05 10:33:26 UTC) #9
haraken
LGTM
4 years, 4 months ago (2016-08-05 12:01:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218863002/20001
4 years, 4 months ago (2016-08-05 12:07:42 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 12:11:59 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 12:14:27 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/795763cbbdf49f52dc0879f3405575bded157623
Cr-Commit-Position: refs/heads/master@{#410037}

Powered by Google App Engine
This is Rietveld 408576698