Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 221883004: drive: Remove unused GData WAPI requests (Closed)

Created:
6 years, 8 months ago by hashimoto
Modified:
6 years, 8 months ago
Reviewers:
kinaba
CC:
chromium-reviews
Visibility:
Public.

Description

drive: Remove unused GData WAPI requests GetResourceEntryReqeust is used by DriveAPIService BUG=357038 TEST=build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261413

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2502 lines) Patch
M google_apis/drive/gdata_wapi_requests.h View 2 chunks +0 lines, -442 lines 0 comments Download
M google_apis/drive/gdata_wapi_requests.cc View 2 chunks +0 lines, -647 lines 0 comments Download
M google_apis/drive/gdata_wapi_requests_unittest.cc View 7 chunks +10 lines, -1413 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
hashimoto
6 years, 8 months ago (2014-04-03 03:38:27 UTC) #1
kinaba
lgtm
6 years, 8 months ago (2014-04-03 03:44:38 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-04-03 03:45:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/221883004/1
6 years, 8 months ago (2014-04-03 03:49:42 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 10:12:40 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 10:12:40 UTC) #6
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-04-03 10:13:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/221883004/1
6 years, 8 months ago (2014-04-03 10:15:24 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 11:25:54 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=293183
6 years, 8 months ago (2014-04-03 11:25:55 UTC) #10
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-04-03 11:58:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/221883004/1
6 years, 8 months ago (2014-04-03 11:58:05 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 14:59:14 UTC) #13
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 14:59:15 UTC) #14
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-04-03 15:12:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/221883004/1
6 years, 8 months ago (2014-04-03 15:12:41 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 15:36:39 UTC) #17
Message was sent while issue was closed. 
Change committed as 261413

Powered by Google App Engine
This is Rietveld 408576698