Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2218783003:
Remove Windows XP cruft in browser_main_runner.cc (Closed)
|
Created:
4 years, 4 months ago by pwnall Modified:
4 years, 1 month ago Reviewers:
Ben Goodger (Google) CC:
chromium-reviews, jam, darin-cc_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove Windows XP cruft in browser_main_runner.cc
BUG=635028
Patch Set 1 : Rebased against master #Patch Set 2 : Rebased. #Messages
Total messages: 26 (18 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
The CQ bit was checked by pwnall@chromium.org to run a CQ dry run
The CQ bit was unchecked by pwnall@chromium.org
The CQ bit was checked by pwnall@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I ran into an XP-specific piece of code while reading up on Chromium. AFAIK, we no longer support XP, so I figured we should get rid of the cruft.
Description was changed from ========== Remove Windows XP cruft in browser_main_runner.cc BUG= ========== to ========== Remove Windows XP cruft in browser_main_runner.cc BUG= ==========
pwnall@chromium.org changed reviewers: + ben@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Remove Windows XP cruft in browser_main_runner.cc BUG= ========== to ========== Remove Windows XP cruft in browser_main_runner.cc BUG=635028 ==========
Ben, can you please take a look at this? Thank you very much!
The CQ bit was checked by pwnall@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Ping? Can you please take a look?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
On 2016/11/13 at 03:57:47, ben wrote: > lgtm Thank you very much!
The CQ bit was checked by pwnall@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove Windows XP cruft in browser_main_runner.cc BUG=635028 ========== to ========== Remove Windows XP cruft in browser_main_runner.cc BUG=635028 Committed: https://crrev.com/9fd27ddeb13974b24cfa42261b940f8de378117a Cr-Commit-Position: refs/heads/master@{#431801} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9fd27ddeb13974b24cfa42261b940f8de378117a Cr-Commit-Position: refs/heads/master@{#431801}
Message was sent while issue was closed.
Description was changed from ========== Remove Windows XP cruft in browser_main_runner.cc BUG=635028 Committed: https://crrev.com/9fd27ddeb13974b24cfa42261b940f8de378117a Cr-Commit-Position: refs/heads/master@{#431801} ========== to ========== Remove Windows XP cruft in browser_main_runner.cc BUG=635028 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) |
