Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2218773004:
Fail with a clear error if the required SDK is not installed. (Closed)
DescriptionFail with a clear error if the required SDK is not installed.
If the --verify flag is passed to //build/mac/find_sdk.py and the SDK
is not installed, the script must fail with a non zero return code or
gn will consider that the script was successful and will discard its
stderr.
Fixes the following error when trying to generate official chrome
branded build with Xcode 8 (that does not ship with macOS 10.10 SDK):
ERROR at //build/config/mac/mac_sdk.gni:43:34: Array subscript out of range.
mac_sdk_version = find_sdk_lines[1]
^
You gave me 1 but I was expecting something from 0 to 1, inclusive.
BUG=634373
Committed: https://crrev.com/c301ead9cb14859d0e4187a7170eeb4fd6b99aec
Cr-Commit-Position: refs/heads/master@{#410529}
Patch Set 1 #
Messages
Total messages: 25 (16 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
sdefresne@chromium.org changed reviewers: + rsesek@chromium.org
Please take a look.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sdefresne@chromium.org changed reviewers: + thomasvl@chromium.org - rsesek@chromium.org
-rsesek, +thomasvl: sending review to an OWNERS.
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from
==========
Fail with a clear error if the required SDK is not installed.
If the --verify flag is passed to //build/mac/find_sdk.py and the SDK
is not installed, the script must fail with a non zero return code or
gn will consider that the scritp was successfull and will discard its
stderr.
Fixes the following error when trying to generate official chrome
branded build with Xcode 8 (that does not ship with macOS 10.10 SDK):
ERROR at //build/config/mac/mac_sdk.gni:43:34: Array subscript out of range.
mac_sdk_version = find_sdk_lines[1]
^
You gave me 1 but I was expecting something from 0 to 1, inclusive.
BUG=634373
==========
to
==========
Fail with a clear error if the required SDK is not installed.
If the --verify flag is passed to //build/mac/find_sdk.py and the SDK
is not installed, the script must fail with a non zero return code or
gn will consider that the script was successful and will discard its
stderr.
Fixes the following error when trying to generate official chrome
branded build with Xcode 8 (that does not ship with macOS 10.10 SDK):
ERROR at //build/config/mac/mac_sdk.gni:43:34: Array subscript out of range.
mac_sdk_version = find_sdk_lines[1]
^
You gave me 1 but I was expecting something from 0 to 1, inclusive.
BUG=634373
==========
rsesek@chromium.org changed reviewers: + mark@chromium.org, rsesek@chromium.org - thomasvl@chromium.org
TVL doesn't work on Chrome anymore. LGTM and adding mark@ for OWNERS.
On 2016/08/08 17:52:32, Robert Sesek wrote: > TVL doesn't work on Chrome anymore. LGTM and adding mark@ for OWNERS. Thank you. Should we update the OWNERS file?
On 2016/08/08 18:03:19, sdefresne (travelling - slow) wrote: > On 2016/08/08 17:52:32, Robert Sesek wrote: > > TVL doesn't work on Chrome anymore. LGTM and adding mark@ for OWNERS. > > Thank you. Should we update the OWNERS file? Yeah, should probably swap me for thomasvl@.
On 2016/08/08 18:05:25, Robert Sesek wrote: > On 2016/08/08 18:03:19, sdefresne (travelling - slow) wrote: > > On 2016/08/08 17:52:32, Robert Sesek wrote: > > > TVL doesn't work on Chrome anymore. LGTM and adding mark@ for OWNERS. > > > > Thank you. Should we update the OWNERS file? > > Yeah, should probably swap me for thomasvl@. Sending to CQ as rsesek@ is now an OWNERS of //build/mac.
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
Fail with a clear error if the required SDK is not installed.
If the --verify flag is passed to //build/mac/find_sdk.py and the SDK
is not installed, the script must fail with a non zero return code or
gn will consider that the script was successful and will discard its
stderr.
Fixes the following error when trying to generate official chrome
branded build with Xcode 8 (that does not ship with macOS 10.10 SDK):
ERROR at //build/config/mac/mac_sdk.gni:43:34: Array subscript out of range.
mac_sdk_version = find_sdk_lines[1]
^
You gave me 1 but I was expecting something from 0 to 1, inclusive.
BUG=634373
==========
to
==========
Fail with a clear error if the required SDK is not installed.
If the --verify flag is passed to //build/mac/find_sdk.py and the SDK
is not installed, the script must fail with a non zero return code or
gn will consider that the script was successful and will discard its
stderr.
Fixes the following error when trying to generate official chrome
branded build with Xcode 8 (that does not ship with macOS 10.10 SDK):
ERROR at //build/config/mac/mac_sdk.gni:43:34: Array subscript out of range.
mac_sdk_version = find_sdk_lines[1]
^
You gave me 1 but I was expecting something from 0 to 1, inclusive.
BUG=634373
==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from
==========
Fail with a clear error if the required SDK is not installed.
If the --verify flag is passed to //build/mac/find_sdk.py and the SDK
is not installed, the script must fail with a non zero return code or
gn will consider that the script was successful and will discard its
stderr.
Fixes the following error when trying to generate official chrome
branded build with Xcode 8 (that does not ship with macOS 10.10 SDK):
ERROR at //build/config/mac/mac_sdk.gni:43:34: Array subscript out of range.
mac_sdk_version = find_sdk_lines[1]
^
You gave me 1 but I was expecting something from 0 to 1, inclusive.
BUG=634373
==========
to
==========
Fail with a clear error if the required SDK is not installed.
If the --verify flag is passed to //build/mac/find_sdk.py and the SDK
is not installed, the script must fail with a non zero return code or
gn will consider that the script was successful and will discard its
stderr.
Fixes the following error when trying to generate official chrome
branded build with Xcode 8 (that does not ship with macOS 10.10 SDK):
ERROR at //build/config/mac/mac_sdk.gni:43:34: Array subscript out of range.
mac_sdk_version = find_sdk_lines[1]
^
You gave me 1 but I was expecting something from 0 to 1, inclusive.
BUG=634373
Committed: https://crrev.com/c301ead9cb14859d0e4187a7170eeb4fd6b99aec
Cr-Commit-Position: refs/heads/master@{#410529}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c301ead9cb14859d0e4187a7170eeb4fd6b99aec Cr-Commit-Position: refs/heads/master@{#410529} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
