Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2218773003: Rework Overstroke GM to show differences between expected and actual (Closed)

Created:
4 years, 4 months ago by Harry Stern
Modified:
4 years, 4 months ago
Reviewers:
caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rework Overstroke GM to show differences between expected and actual Draw the perpendiculars of the curve with the stroke width. See Cary's SampleQuadStroker.cpp for what we are attempting to mimic. BUG=589769, skia:5405, skia:5406 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2218773003 Committed: https://skia.googlesource.com/skia/+/bb9b2247a2bacb1a894d83762a3edb115ee3819d

Patch Set 1 #

Patch Set 2 : Add note regarding nvpr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -35 lines) Patch
M gm/OverStroke.cpp View 1 11 chunks +73 lines, -35 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Harry Stern
Forgot to send this out
4 years, 4 months ago (2016-08-08 21:58:59 UTC) #4
reed1
lgtm
4 years, 4 months ago (2016-08-09 14:10:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218773003/20001
4 years, 4 months ago (2016-08-09 15:36:59 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 15:53:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bb9b2247a2bacb1a894d83762a3edb115ee3819d

Powered by Google App Engine
This is Rietveld 408576698