MacViews: Underline composition text.

MacViews: Underline composition text.

This CL adds a black underline to the active composition text for textfields on
MacViews. This makes the behavior of IME on MacViews' textfields, the same as
that on other Views platforms.

BUG=612675
TEST=Enable chrome://flags/#mac-views-native-dialogs. Go to system settings and
change Input Source to Katakana(Japanese). Open Bookmark bubble. In the Name:
textfield, press "kv" and then press Enter. Press "mq". Ensure mq is underlined.

Committed: https://crrev.com/2ccee9b698c96a58655cf5ff7e07048b3fb22962
Cr-Commit-Position: refs/heads/master@{#410007}

[karandeepb, 2016-08-05 03:59:30]

Description was changed from

==========
MacViews: Underline composition text.
==========

to

==========
MacViews: Underline composition text.

This CL adds a black underline to the active composition text for textfields on
MacViews. This makes the behavior of IME on MacViews' textfields, the same as 
that on other Views platforms. 

BUG=612675 
TEST=Enable chrome://flags/#mac-views-native-dialogs. Go to system settings and
change Input Source to Katakana(Japanese). Open Bookmark bubble. In the Name:
textfield, press "kv" and then press Enter. Press "mq". Ensure mq is underlined.
==========

[karandeepb, 2016-08-05 04:03:38]

karandeepb@chromium.org changed reviewers:
+ tapted@chromium.org

[karandeepb, 2016-08-05 04:03:39]

PTAL Trent.

[tapted, 2016-08-05 05:46:50]

lgtm

https://codereview.chromium.org/2218773002/diff/20001/ui/views/cocoa/bridged_...
File ui/views/cocoa/bridged_content_view.mm (right):

https://codereview.chromium.org/2218773002/diff/20001/ui/views/cocoa/bridged_...
ui/views/cocoa/bridged_content_view.mm:1247: // underlines for consecutive
characters.
nit: The TODO should cite a bug. You can probably repurpose 612675 and just put

See http://crbug.com/612675.

at the end of this line.

[karandeepb, 2016-08-05 06:16:05]

https://codereview.chromium.org/2218773002/diff/20001/ui/views/cocoa/bridged_...
File ui/views/cocoa/bridged_content_view.mm (right):

https://codereview.chromium.org/2218773002/diff/20001/ui/views/cocoa/bridged_...
ui/views/cocoa/bridged_content_view.mm:1247: // underlines for consecutive
characters.
On 2016/08/05 05:46:50, tapted wrote:
> nit: The TODO should cite a bug. You can probably repurpose 612675 and just
put
> 
> See http://crbug.com/612675.
> 
> at the end of this line.

Done.

[karandeepb, 2016-08-05 06:16:12]

The CQ bit was checked by karandeepb@chromium.org

[karandeepb, 2016-08-05 06:16:12]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2218773002/#ps40001
(title: "Address nit.")

[commit-bot: I haz the power, 2016-08-05 06:16:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 07:02:26]

Description was changed from

==========
MacViews: Underline composition text.

This CL adds a black underline to the active composition text for textfields on
MacViews. This makes the behavior of IME on MacViews' textfields, the same as 
that on other Views platforms. 

BUG=612675 
TEST=Enable chrome://flags/#mac-views-native-dialogs. Go to system settings and
change Input Source to Katakana(Japanese). Open Bookmark bubble. In the Name:
textfield, press "kv" and then press Enter. Press "mq". Ensure mq is underlined.
==========

to

==========
MacViews: Underline composition text.

This CL adds a black underline to the active composition text for textfields on
MacViews. This makes the behavior of IME on MacViews' textfields, the same as 
that on other Views platforms. 

BUG=612675 
TEST=Enable chrome://flags/#mac-views-native-dialogs. Go to system settings and
change Input Source to Katakana(Japanese). Open Bookmark bubble. In the Name:
textfield, press "kv" and then press Enter. Press "mq". Ensure mq is underlined.
==========

[commit-bot: I haz the power, 2016-08-05 07:02:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-05 07:04:14]

Description was changed from

==========
MacViews: Underline composition text.

This CL adds a black underline to the active composition text for textfields on
MacViews. This makes the behavior of IME on MacViews' textfields, the same as 
that on other Views platforms. 

BUG=612675 
TEST=Enable chrome://flags/#mac-views-native-dialogs. Go to system settings and
change Input Source to Katakana(Japanese). Open Bookmark bubble. In the Name:
textfield, press "kv" and then press Enter. Press "mq". Ensure mq is underlined.
==========

to

==========
MacViews: Underline composition text.

This CL adds a black underline to the active composition text for textfields on
MacViews. This makes the behavior of IME on MacViews' textfields, the same as
that on other Views platforms.

BUG=612675
TEST=Enable chrome://flags/#mac-views-native-dialogs. Go to system settings and
change Input Source to Katakana(Japanese). Open Bookmark bubble. In the Name:
textfield, press "kv" and then press Enter. Press "mq". Ensure mq is underlined.

Committed: https://crrev.com/2ccee9b698c96a58655cf5ff7e07048b3fb22962
Cr-Commit-Position: refs/heads/master@{#410007}
==========

[commit-bot: I haz the power, 2016-08-05 07:04:15]

Patchset 3 (id:??) landed as
https://crrev.com/2ccee9b698c96a58655cf5ff7e07048b3fb22962
Cr-Commit-Position: refs/heads/master@{#410007}