Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2218773002: MacViews: Underline composition text. (Closed)

Created:
4 years, 4 months ago by karandeepb
Modified:
4 years, 4 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Underline composition text. This CL adds a black underline to the active composition text for textfields on MacViews. This makes the behavior of IME on MacViews' textfields, the same as that on other Views platforms. BUG=612675 TEST=Enable chrome://flags/#mac-views-native-dialogs. Go to system settings and change Input Source to Katakana(Japanese). Open Bookmark bubble. In the Name: textfield, press "kv" and then press Enter. Press "mq". Ensure mq is underlined. Committed: https://crrev.com/2ccee9b698c96a58655cf5ff7e07048b3fb22962 Cr-Commit-Position: refs/heads/master@{#410007}

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 : Address nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ui/views/cocoa/bridged_content_view.mm View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
karandeepb
PTAL Trent.
4 years, 4 months ago (2016-08-05 04:03:39 UTC) #3
tapted
lgtm https://codereview.chromium.org/2218773002/diff/20001/ui/views/cocoa/bridged_content_view.mm File ui/views/cocoa/bridged_content_view.mm (right): https://codereview.chromium.org/2218773002/diff/20001/ui/views/cocoa/bridged_content_view.mm#newcode1247 ui/views/cocoa/bridged_content_view.mm:1247: // underlines for consecutive characters. nit: The TODO ...
4 years, 4 months ago (2016-08-05 05:46:50 UTC) #4
karandeepb
https://codereview.chromium.org/2218773002/diff/20001/ui/views/cocoa/bridged_content_view.mm File ui/views/cocoa/bridged_content_view.mm (right): https://codereview.chromium.org/2218773002/diff/20001/ui/views/cocoa/bridged_content_view.mm#newcode1247 ui/views/cocoa/bridged_content_view.mm:1247: // underlines for consecutive characters. On 2016/08/05 05:46:50, tapted ...
4 years, 4 months ago (2016-08-05 06:16:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218773002/40001
4 years, 4 months ago (2016-08-05 06:16:40 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-05 07:02:27 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 07:04:15 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2ccee9b698c96a58655cf5ff7e07048b3fb22962
Cr-Commit-Position: refs/heads/master@{#410007}

Powered by Google App Engine
This is Rietveld 408576698