Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 2218743003: [test] don't use Intl.Collator in non-Intl regression test (Closed)

Created:
4 years, 4 months ago by caitp
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] don't use Intl.Collator in non-Intl regression test Unskip test which failed with Intl support disabled, and avoid using Intl objects within the test. BUG=chromium:634273, chromium:634357, v8:5162 NOTRY=true R=mstarzinger@chromium.org Committed: https://crrev.com/6cd494feada97744564843de2bbf1007267faa65 Cr-Commit-Position: refs/heads/master@{#38384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M test/mjsunit/es7/regress/regress-634357.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
caitp
Hi, here's a fixup. PTAL
4 years, 4 months ago (2016-08-05 12:46:14 UTC) #1
Michael Starzinger
4 years, 4 months ago (2016-08-05 12:47:06 UTC) #2
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-08-05 12:47:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218743003/1
4 years, 4 months ago (2016-08-05 12:48:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 12:54:28 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 12:56:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cd494feada97744564843de2bbf1007267faa65
Cr-Commit-Position: refs/heads/master@{#38384}

Powered by Google App Engine
This is Rietveld 408576698