Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 221873006: Fixed a variable that may be used uninitialized. (Closed)

Created:
6 years, 8 months ago by Fabrice (no longer in Chrome)
Modified:
6 years, 8 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fixed a variable that may be used uninitialized. Prevents a warning with GCC 4.8 on Android. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Fabrice de Gans (Google)
GCC 4.8 complains this variable might be used uninitialized. While the current logic makes this ...
6 years, 8 months ago (2014-04-02 14:09:05 UTC) #1
Nico
lgtm In general, I think we should disable warnings with false positives like this, but ...
6 years, 8 months ago (2014-04-02 14:53:43 UTC) #2
Fabrice (no longer in Chrome)
On 2014/04/02 14:53:43, Nico wrote: > lgtm > > In general, I think we should ...
6 years, 8 months ago (2014-04-02 15:02:27 UTC) #3
Fabrice (no longer in Chrome)
The CQ bit was checked by fdegans@chromium.org
6 years, 8 months ago (2014-04-02 15:02:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fdegans@chromium.org/221873006/1
6 years, 8 months ago (2014-04-02 15:02:33 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 17:57:07 UTC) #6
Message was sent while issue was closed.
Change committed as 170675

Powered by Google App Engine
This is Rietveld 408576698