Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2950)

Unified Diff: chrome/browser/chromeos/extensions/wallpaper_api.cc

Issue 221873005: Some cleanup of WallpaperManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Compilation fix. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/wallpaper_api.cc
diff --git a/chrome/browser/chromeos/extensions/wallpaper_api.cc b/chrome/browser/chromeos/extensions/wallpaper_api.cc
index 1c9e50ab46860f86da51bbd3b80348a2af7d2d62..383c7c7fb9b01db6eab7acc1b1c7578a9df8bd80 100644
--- a/chrome/browser/chromeos/extensions/wallpaper_api.cc
+++ b/chrome/browser/chromeos/extensions/wallpaper_api.cc
@@ -119,13 +119,9 @@ bool WallpaperSetWallpaperFunction::RunImpl() {
}
void WallpaperSetWallpaperFunction::OnWallpaperDecoded(
- const gfx::ImageSkia& wallpaper) {
+ const gfx::ImageSkia& image) {
chromeos::WallpaperManager* wallpaper_manager =
chromeos::WallpaperManager::Get();
- chromeos::UserImage::RawImage raw_image(
- params_->details.wallpaper_data->begin(),
- params_->details.wallpaper_data->end());
- chromeos::UserImage image(wallpaper, raw_image);
base::FilePath thumbnail_path = wallpaper_manager->GetCustomWallpaperPath(
chromeos::kThumbnailWallpaperSubDir,
user_id_hash_,
@@ -151,14 +147,16 @@ void WallpaperSetWallpaperFunction::OnWallpaperDecoded(
unsafe_wallpaper_decoder_ = NULL;
if (params_->details.thumbnail) {
- wallpaper.EnsureRepsForSupportedScales();
- scoped_ptr<gfx::ImageSkia> deep_copy(wallpaper.DeepCopy());
+ image.EnsureRepsForSupportedScales();
+ scoped_ptr<gfx::ImageSkia> deep_copy(image.DeepCopy());
// Generates thumbnail before call api function callback. We can then
// request thumbnail in the javascript callback.
- task_runner->PostTask(FROM_HERE,
- base::Bind(
- &WallpaperSetWallpaperFunction::GenerateThumbnail,
- this, thumbnail_path, base::Passed(&deep_copy)));
+ task_runner->PostTask(
+ FROM_HERE,
+ base::Bind(&WallpaperSetWallpaperFunction::GenerateThumbnail,
+ this,
+ thumbnail_path,
+ base::Passed(deep_copy.Pass())));
} else {
SendResponse(true);
}
@@ -168,13 +166,12 @@ void WallpaperSetWallpaperFunction::GenerateThumbnail(
const base::FilePath& thumbnail_path, scoped_ptr<gfx::ImageSkia> image) {
DCHECK(BrowserThread::GetBlockingPool()->IsRunningSequenceOnCurrentThread(
sequence_token_));
- chromeos::UserImage wallpaper(*image.get());
if (!base::PathExists(thumbnail_path.DirName()))
base::CreateDirectory(thumbnail_path.DirName());
scoped_refptr<base::RefCountedBytes> data;
- chromeos::WallpaperManager::Get()->ResizeWallpaper(
- wallpaper,
+ chromeos::WallpaperManager::Get()->ResizeImage(
+ *image,
ash::WALLPAPER_LAYOUT_STRETCH,
chromeos::kWallpaperThumbnailWidth,
chromeos::kWallpaperThumbnailHeight,
« no previous file with comments | « chrome/browser/chromeos/extensions/wallpaper_api.h ('k') | chrome/browser/chromeos/extensions/wallpaper_private_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698