Some cleanup of WallpaperManager.

chrome/browser/chromeos/login/user.h

Index: chrome/browser/chromeos/login/user.h
diff --git a/chrome/browser/chromeos/login/user.h b/chrome/browser/chromeos/login/user.h
index a55365179c0a00c9a2d391cb462ba6ce3853b449..5864b475f59af896da773a50cfd507e9f3fa8866 100644
--- a/chrome/browser/chromeos/login/user.h
+++ b/chrome/browser/chromeos/login/user.h
@@ -107,13 +107,12 @@ class User {
   static const int kProfileImageIndex = -2;
   static const int kInvalidImageIndex = -3;
 
+  // Enum values 0 and 3 have been removed.  Do not re-use them!

[Nikita (slow), 2014/04/18 09:28:19]

nit: How about using this syntax:
This way it is more clear what these indices were used for.

 /* DAILY = 0 */  // Removed.  Do not re-use the id!

 /* UNKNOWN = 3 */  // Removed.  Do not re-use the id!

[Thiemo Nagel, 2014/04/23 17:14:06]

Done.  (I had modeled the syntax after that of the OAuthTokenStatus enum, but I
don't mind either way.)

   enum WallpaperType {
-    DAILY = 0,
-    CUSTOMIZED = 1,
-    DEFAULT = 2,
-    /* UNKNOWN = 3 */  // Removed.  Do not re-use the id!
-    ONLINE = 4,
-    POLICY = 5,        // Controlled by policy, can't be changed by the user.
+    CUSTOMIZED = 1,  // Selected by user.
+    DEFAULT = 2,     // Default.
+    ONLINE = 4,      // WallpaperInfo.file denotes an URL.
+    POLICY = 5,      // Controlled by policy, can't be changed by the user.
     WALLPAPER_TYPE_COUNT = 6
   };