sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart - Issue 221873002: Compute frontend/backend specific constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

Issue 221873002: Compute frontend/backend specific constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixes Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

index 201260435fc9845fb92e563b0d247c2679c25ea4..7440372180068355b8a5618668a175803defb938 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

@@ -236,7 +236,9 @@ class Dart2JsParameterMirror extends Dart2JsMemberMirror

InstanceMirror get defaultValue {

if (hasDefaultValue) {

- Constant constant = mirrorSystem.compiler.constantHandler

+ // TODO(johnniwinther): Get the constant from the [TreeElements]

+ // associated with the enclosing method.

+ Constant constant = mirrorSystem.compiler.constants

.getConstantForVariable(_element);

assert(invariant(_element, constant != null,

message: "Missing constant for parameter "