sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart - Issue 221873002: Compute frontend/backend specific constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

Issue 221873002: Compute frontend/backend specific constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Classes renamed and comments added. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

index 231035a42efce9cc6a30e789781a8005e7d5bc2b..14dd8c6101a3b155155d725a3eb9b6d52aa53a84 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

@@ -842,7 +842,7 @@ class CodeEmitterTask extends CompilerTask {

}

void emitStaticNonFinalFieldInitializations(CodeBuffer buffer) {

- ConstantHandler handler = compiler.constantHandler;

+ JavaScriptConstantCompiler handler = backend.constants;

Iterable<VariableElement> staticNonFinalFields =

handler.getStaticNonFinalFieldsForEmission();

for (Element element in Elements.sortedByPosition(staticNonFinalFields)) {

@@ -862,7 +862,7 @@ class CodeEmitterTask extends CompilerTask {

}

void emitLazilyInitializedStaticFields(CodeBuffer buffer) {

- ConstantHandler handler = compiler.constantHandler;

+ JavaScriptConstantCompiler handler = backend.constants;

List<VariableElement> lazyFields =

handler.getLazilyInitializedFieldsForEmission();

if (!lazyFields.isEmpty) {

@@ -901,7 +901,7 @@ class CodeEmitterTask extends CompilerTask {

}

void emitCompileTimeConstants(CodeBuffer buffer, OutputUnit outputUnit) {

- ConstantHandler handler = compiler.constantHandler;

+ JavaScriptConstantCompiler handler = backend.constants;

List<Constant> constants = handler.getConstantsForEmission(

compareConstants);

Set<Constant> outputUnitConstants = null;