Archive SDK by git hash in addition to version number

tools/bots/dart_sdk.py

Index: tools/bots/dart_sdk.py
diff --git a/tools/bots/dart_sdk.py b/tools/bots/dart_sdk.py
index 00e7d35db646bf0be42bfbec50ac1f31615276bd..ce1f7944735e8263de50f7f21e8009f522b8c975 100644
--- a/tools/bots/dart_sdk.py
+++ b/tools/bots/dart_sdk.py
@@ -81,8 +81,9 @@ def CreateUploadSDKZips():
 
 def DartArchiveUploadSDKs(system, sdk32_zip, sdk64_zip):
   namer = bot_utils.GCSNamer(CHANNEL, bot_utils.ReleaseType.RAW)
-  revision = utils.GetArchiveVersion()
-  for revision in [revision, 'latest']:
+  git_number = utils.GetArchiveVersion()

[kustermann, 2016/08/05 11:32:37]

Is this really a number of a semantic version? If the latter, maybe rename to
semver (or something like that).

[Bill Hesse, 2016/08/05 22:07:28]

This is a consecutive number for 'be', which I want to eliminate, and the
semantic version for 'dev' and 'stable'.

 

+  git_hash = 'hash/' + utils.GetGitRevision()

[Bill Hesse, 2016/08/05 11:28:11]

Should I use 'hash/%s' % instead of 'hash/' +?

[kustermann, 2016/08/05 11:32:37]

Yes, I think this is the "python way" of doing it normally.

+  for revision in [git_number, git_hash, 'latest']:
     path32 = namer.sdk_zipfilepath(revision, system, 'ia32', 'release')
     path64 = namer.sdk_zipfilepath(revision, system, 'x64', 'release')
     DartArchiveFile(sdk32_zip, path32, checksum_files=True)