Archive SDK by git hash in addition to version number

Archive SDK by git hash in addition to version number

This is needed for buildbot testers to download the SDK instead of building it.

BUG=
R=kustermann@google.com

Committed: https://github.com/dart-lang/sdk/commit/8473409b9ca7398042a9cbaff8daefe2921c36c2

[Bill Hesse, 2016-08-05 11:28:11]

whesse@google.com changed reviewers:
+ kustermann@google.com

[Bill Hesse, 2016-08-05 11:28:11]

https://codereview.chromium.org/2218723003/diff/1/tools/bots/dart_sdk.py
File tools/bots/dart_sdk.py (right):

https://codereview.chromium.org/2218723003/diff/1/tools/bots/dart_sdk.py#newc...
tools/bots/dart_sdk.py:85: git_hash = 'hash/' + utils.GetGitRevision()
Should I use 'hash/%s' % instead of 'hash/' +?

[kustermann, 2016-08-05 11:32:37]

LGTM

https://codereview.chromium.org/2218723003/diff/1/tools/bots/dart_sdk.py
File tools/bots/dart_sdk.py (right):

https://codereview.chromium.org/2218723003/diff/1/tools/bots/dart_sdk.py#newc...
tools/bots/dart_sdk.py:84: git_number = utils.GetArchiveVersion()
Is this really a number of a semantic version? If the latter, maybe rename to
semver (or something like that).

https://codereview.chromium.org/2218723003/diff/1/tools/bots/dart_sdk.py#newc...
tools/bots/dart_sdk.py:85: git_hash = 'hash/' + utils.GetGitRevision()
On 2016/08/05 11:28:11, Bill Hesse wrote:
> Should I use 'hash/%s' % instead of 'hash/' +?

Yes, I think this is the "python way" of doing it normally.

[Bill Hesse, 2016-08-05 11:39:00]

Description was changed from

==========
Archive SDK by git hash in addition to version number

This is needed for buildbot testers to download the SDK instead of building it.

BUG=
==========

to

==========
Archive SDK by git hash in addition to version number

This is needed for buildbot testers to download the SDK instead of building it.

BUG=
R=kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8473409b9ca7398042a9cbaff8daefe2921c36c2
==========

[Bill Hesse, 2016-08-05 11:39:01]

Committed patchset #1 (id:1) manually as
8473409b9ca7398042a9cbaff8daefe2921c36c2 (presubmit successful).

[Bill Hesse, 2016-08-05 22:07:28]

https://codereview.chromium.org/2218723003/diff/1/tools/bots/dart_sdk.py
File tools/bots/dart_sdk.py (right):

https://codereview.chromium.org/2218723003/diff/1/tools/bots/dart_sdk.py#newc...
tools/bots/dart_sdk.py:84: git_number = utils.GetArchiveVersion()
On 2016/08/05 11:32:37, kustermann wrote:
> Is this really a number of a semantic version? If the latter, maybe rename to
> semver (or something like that).

This is a consecutive number for 'be', which I want to eliminate, and the
semantic version for 'dev' and 'stable'.