Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2218713002: MD Settings: Bluetooth polish (Closed)

Created:
4 years, 4 months ago by stevenjb
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Bluetooth polish Some extra bluettoth polish: * Fixed height for the bluetooth dialog * Correctly center dialog contents * Blue spinners for all chrome WebUI * Focus dialog inputs BUG=602538 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/003a037bb7b06772d7a4d06abc01b18b012229a6 Cr-Commit-Position: refs/heads/master@{#412604}

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : Rebase + wrap #

Patch Set 4 : Clang fixes + cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -122 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html View 1 2 3 4 chunks +60 lines, -50 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js View 1 2 3 12 chunks +76 lines, -72 lines 0 comments Download
M ui/webui/resources/cr_elements/shared_style_css.html View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
stevenjb
Note: The majority of the change to bluetooth_device_dialog.html is some extra indent which appears to ...
4 years, 4 months ago (2016-08-05 01:43:37 UTC) #3
stevenjb
ping
4 years, 4 months ago (2016-08-12 00:37:07 UTC) #5
Dan Beam
lgtm https://codereview.chromium.org/2218713002/diff/1/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html (right): https://codereview.chromium.org/2218713002/diff/1/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html#newcode43 chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:43: div.contents { nit: unless it's necessary, I'd drop ...
4 years, 4 months ago (2016-08-12 00:43:29 UTC) #6
stevenjb
https://codereview.chromium.org/2218713002/diff/20001/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html (right): https://codereview.chromium.org/2218713002/diff/20001/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html#newcode45 chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:45: min-height: 250px; On 2016/08/12 00:43:28, Dan Beam wrote: > ...
4 years, 4 months ago (2016-08-15 20:40:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218713002/40001
4 years, 4 months ago (2016-08-15 20:40:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/1896)
4 years, 4 months ago (2016-08-15 20:52:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218713002/60001
4 years, 4 months ago (2016-08-17 18:21:49 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-17 19:04:34 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 19:08:13 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/003a037bb7b06772d7a4d06abc01b18b012229a6
Cr-Commit-Position: refs/heads/master@{#412604}

Powered by Google App Engine
This is Rietveld 408576698