chromeos/system/fake_statistics_provider.h - Issue 2218703006: Clean up handling of invalid HWID when running ChromeOS in VMs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/system/fake_statistics_provider.h

Issue 2218703006: Clean up handling of invalid HWID when running ChromeOS in VMs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/hwid_checker.cc ('K') | « chrome/browser/chromeos/login/hwid_checker.cc ('k') | chromeos/system/fake_statistics_provider.cc » ('j') | chromeos/system/statistics_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/system/fake_statistics_provider.h

diff --git a/chromeos/system/fake_statistics_provider.h b/chromeos/system/fake_statistics_provider.h

index d7f1c35be963c1977216b2b340c38e0fd6c0563b..78c540cfa616bea67d030ffe7ed1094cc1cbca2d 100644

--- a/chromeos/system/fake_statistics_provider.h

+++ b/chromeos/system/fake_statistics_provider.h

@@ -28,6 +28,7 @@ class FakeStatisticsProvider : public StatisticsProvider {

std::string* result) override;

bool GetMachineFlag(const std::string& name, bool* result) override;

void Shutdown() override;

+ bool IsRunningOnVm() override;

achuithb 2016/08/10 18:24:58 Feels like this should be const, but I guess GetMa

norvez 2016/08/11 17:10:34 Yes, we have to const-ify all the way down :-(

void SetMachineStatistic(const std::string& key, const std::string& value);

void ClearMachineStatistic(const std::string& key);