Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1911)

Unified Diff: chrome/browser/chromeos/login/hwid_checker.cc

Issue 2218703006: Clean up handling of invalid HWID when running ChromeOS in VMs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: crossystem command changed from is_in_vm to inside_vm Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/system/statistics_provider.h » ('j') | chromeos/system/statistics_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/hwid_checker.cc
diff --git a/chrome/browser/chromeos/login/hwid_checker.cc b/chrome/browser/chromeos/login/hwid_checker.cc
index 334e52035cc01088080119d129c46a00fca6c716..3488c3f884f5adbb7758c427c6dadd02c19e53ef 100644
--- a/chrome/browser/chromeos/login/hwid_checker.cc
+++ b/chrome/browser/chromeos/login/hwid_checker.cc
@@ -127,25 +127,16 @@ bool IsMachineHWIDCorrect() {
return false;
}
if (!chromeos::IsHWIDCorrect(hwid)) {
- // Log the system vendor info to see what the system vendor is on the GCE
- // VMs. This info will be used to filter out error messages on VMs. See
- // http://crbug.com/585514 and http://crbug.com/585515 for more info.
std::string system_vendor;
stats->GetMachineStatistic(chromeos::system::kSystemVendorKey,
&system_vendor);
- std::string firmware_type;
- const bool non_chrome_firmware =
- stats->GetMachineStatistic(chromeos::system::kFirmwareTypeKey,
- &firmware_type) &&
- firmware_type == system::kFirmwareTypeValueNonchrome;
- if (non_chrome_firmware) {
- LOG(WARNING) << "Detected non-Chrome firmware with malformed HWID '"
- << hwid << "', assuming VM environment. "
- << "The system vendor is '" << system_vendor << "'.";
- } else {
+ if (!chromeos::system::isRunningOnChromeOSVM()) {
Daniel Erat 2016/08/10 13:58:05 s/is/Is/ (see style guide)
LOG(ERROR) << "Machine has malformed HWID '" << hwid << "'. "
<< "The system vendor is '" << system_vendor << "'.";
return false;
+ } else {
+ LOG(WARNING) << "The system is a VM. The system vendor is '"
+ << system_vendor << "'.";
}
}
return true;
« no previous file with comments | « no previous file | chromeos/system/statistics_provider.h » ('j') | chromeos/system/statistics_provider.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698