Clean up handling of invalid HWID when running ChromeOS in VMs

chrome/browser/chromeos/login/hwid_checker_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/sys_info.h"
+#include "base/test/scoped_command_line.h"
+#include "base/time/time.h"
 #include "chrome/browser/chromeos/login/hwid_checker.h"
-
+#include "chromeos/system/fake_statistics_provider.h"
+#include "content/public/common/content_switches.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 
 namespace chromeos {
 
 TEST(HWIDCheckerTest, EmptyHWID) {
   EXPECT_FALSE(IsHWIDCorrect(""));
 }
 
 TEST(HWIDCheckerTest, HWIDv2) {
@@ skipping 99 matching lines @@
   EXPECT_TRUE(IsHWIDCorrect("DELL HORIZON MAGENTA 8992"));
   EXPECT_FALSE(IsHWIDCorrect("DELL HORIZ0N MAGENTA 8992"));
 
   EXPECT_TRUE(IsHWIDCorrect("DELL HORIZON MAGENTA DVT 4770"));
   EXPECT_FALSE(IsHWIDCorrect("DELL MAGENTA HORIZON DVT 4770"));
 
   EXPECT_TRUE(IsHWIDCorrect("SAMS ALEX GAMMA DVT 9247"));
   EXPECT_FALSE(IsHWIDCorrect("SAMS ALPX GAMMA DVT 9247"));
 }
 
-} // namespace chromeos
+#if defined(GOOGLE_CHROME_BUILD)
 
+void SetRunningOnChromeOS() {
+  const char kLsbRelease[] =
+      "CHROMEOS_RELEASE_NAME=Chrome OS\n"
+      "CHROMEOS_RELEASE_VERSION=1.2.3.4\n";
+  base::SysInfo::SetChromeOSVersionInfoForTest(kLsbRelease, base::Time());
+}
+
+TEST(MachineHWIDCheckerTest, TestSwitch) {

[achuithb, 2016/08/11 18:40:16]

I think adding a comment describing each test would be useful, though the test
names are a good start.

Also a few newlines in each test would make them more readable - it's currently
very dense.

[norvez, 2016/08/12 10:18:29]

Done.

+  // GIVEN test switch is active.
+  base::test::ScopedCommandLine scoped_command_line;
+  scoped_command_line.GetProcessCommandLine()->AppendSwitch(
+      ::switches::kTestType);

[achuithb, 2016/08/11 18:40:15]

Isn't this always true for unittests? Apparently not, but I don't understand it.
Maybe it's only always true for browser tests?

+  // THEN IsMachineHWIDCorrect() is always true.
+  EXPECT_TRUE(IsMachineHWIDCorrect());
+  SetRunningOnChromeOS();
+  EXPECT_TRUE(IsMachineHWIDCorrect());
+  system::ScopedFakeStatisticsProvider fake_statistics_provider;
+  fake_statistics_provider.SetMachineStatistic(system::kHardwareClassKey,
+                                               "INVALID_HWID");
+  EXPECT_TRUE(IsMachineHWIDCorrect());
+  fake_statistics_provider.ClearMachineStatistic(system::kHardwareClassKey);
+  EXPECT_TRUE(IsMachineHWIDCorrect());
+}
+
+TEST(MachineHWIDCheckerTest, NotOnChromeOS) {
+  // GIVEN The OS is not Chrome OS.
+  base::SysInfo::SetChromeOSVersionInfoForTest("", base::Time());
+  // THEN IsMachineHWIDCorrect() is always true.
+  EXPECT_TRUE(IsMachineHWIDCorrect());
+  system::ScopedFakeStatisticsProvider fake_statistics_provider;
+  fake_statistics_provider.SetMachineStatistic(system::kHardwareClassKey,
+                                               "INVALID_HWID");
+  EXPECT_TRUE(IsMachineHWIDCorrect());
+  fake_statistics_provider.ClearMachineStatistic(system::kHardwareClassKey);
+  EXPECT_TRUE(IsMachineHWIDCorrect());
+}
+
+
+TEST(MachineHWIDCheckerTest, OnCrosNoHWID) {
+  // GIVEN The OS is Chrome OS.
+  SetRunningOnChromeOS();
+  // GIVEN The HWID is not present.
+  system::ScopedFakeStatisticsProvider fake_statistics_provider;
+  fake_statistics_provider.ClearMachineStatistic(system::kHardwareClassKey);
+  // THEN IsMachineHWIDCorrect() is always false.
+  EXPECT_FALSE(IsMachineHWIDCorrect());
+  fake_statistics_provider.SetMachineStatistic(system::kIsVmKey,
+                                               system::kIsVmValueFalse);
+  EXPECT_FALSE(IsMachineHWIDCorrect());
+  fake_statistics_provider.SetMachineStatistic(system::kIsVmKey,
+                                               system::kIsVmValueTrue);
+  EXPECT_FALSE(IsMachineHWIDCorrect());
+}
+
+TEST(MachineHWIDCheckerTest, ValidHWID) {
+  // GIVEN The HWID is valid

[achuithb, 2016/08/11 18:40:16]

nit: period

[norvez, 2016/08/12 10:18:29]

Done.

+  system::ScopedFakeStatisticsProvider fake_statistics_provider;
+  fake_statistics_provider.SetMachineStatistic(system::kHardwareClassKey,
+                                               "DELL HORIZON MAGENTA DVT 4770");
+  // THEN IsMachineHWIDCorrect() is always true.
+  SetRunningOnChromeOS();
+  EXPECT_TRUE(IsMachineHWIDCorrect());
+  fake_statistics_provider.SetMachineStatistic(system::kIsVmKey,
+                                               system::kIsVmValueFalse);
+  EXPECT_TRUE(IsMachineHWIDCorrect());
+  fake_statistics_provider.SetMachineStatistic(system::kIsVmKey,
+                                               system::kIsVmValueTrue);
+  EXPECT_TRUE(IsMachineHWIDCorrect());
+}
+
+TEST(MachineHWIDCheckerTest, InVM) {
+  // GIVEN kIsVmKey is kIsVmValueTrue.
+  system::ScopedFakeStatisticsProvider fake_statistics_provider;
+  fake_statistics_provider.SetMachineStatistic(system::kIsVmKey,
+                                               system::kIsVmValueTrue);
+
+  // GIVEN Any HWID is present.
+  // THEN IsMachineHWIDCorrect() is always true.
+  SetRunningOnChromeOS();
+  fake_statistics_provider.SetMachineStatistic(system::kHardwareClassKey,
+                                               "INVALID_HWID");
+  EXPECT_TRUE(IsMachineHWIDCorrect());
+  fake_statistics_provider.SetMachineStatistic(system::kHardwareClassKey, "");
+  EXPECT_TRUE(IsMachineHWIDCorrect());
+  fake_statistics_provider.SetMachineStatistic(system::kHardwareClassKey,
+                                               "DELL HORIZON MAGENTA DVT 4770");
+  EXPECT_TRUE(IsMachineHWIDCorrect());
+}
+
+TEST(MachineHWIDCheckerTest, InvalidHWIDInVMNotTrue) {
+  // GIVEN The OS is Chrome OS.
+  SetRunningOnChromeOS();
+  // GIVEN The HWID is invalid.
+  system::ScopedFakeStatisticsProvider fake_statistics_provider;
+  fake_statistics_provider.SetMachineStatistic(system::kHardwareClassKey,
+                                               "INVALID_HWID");
+  // GIVEN kIsVmKey is anything but kIsVmValueTrue.
+  // THEN IsMachineHWIDCorrect() is always false.
+  fake_statistics_provider.SetMachineStatistic(system::kIsVmKey,
+                                               system::kIsVmValueFalse);
+  EXPECT_FALSE(IsMachineHWIDCorrect());
+  fake_statistics_provider.SetMachineStatistic(system::kIsVmKey,
+                                               "INVALID_VM_KEY");
+  EXPECT_FALSE(IsMachineHWIDCorrect());
+  fake_statistics_provider.SetMachineStatistic(system::kIsVmKey, "(error)");
+  EXPECT_FALSE(IsMachineHWIDCorrect());
+  fake_statistics_provider.SetMachineStatistic(system::kIsVmKey, "");
+  EXPECT_FALSE(IsMachineHWIDCorrect());
+  fake_statistics_provider.ClearMachineStatistic(system::kIsVmKey);
+  EXPECT_FALSE(IsMachineHWIDCorrect());
+}
+
+#else  // defined(GOOGLE_CHROME_BUILD)
+
+TEST(MachineHWIDCheckerTest, NonGoogleBuild) {
+  // GIVEN This is not a Google build.
+  // THEN IsMachineHWIDCorrect() is always true.
+  EXPECT_TRUE(IsMachineHWIDCorrect());
+}
+
+#endif  // defined(GOOGLE_CHROME_BUILD)
+}  // namespace chromeos
+