Unify memory optimization modes and flags.

Unify memory optimization modes and flags.

This patch folds --optimize-for-size flag and check for low-memory device
into Heap::ShouldOptimizeForMemoryUsage() predicate.

It has the following side effects:
- the heap growing factor for low-memory devices is capped at 1.3 (old value was 2.0).
- the memory reducer will be more aggressive for low-memory devices.

BUG=chromium:634900
Committed: https://crrev.com/6cebf7d963c18e2ab09f2320c949baf0a4bed721
Cr-Commit-Position: refs/heads/master@{#38406}

[ulan, 2016-08-05 14:02:11]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org

[ulan, 2016-08-05 14:02:12]

ptal

[Hannes Payer (out of office), 2016-08-05 14:25:02]

https://codereview.chromium.org/2218703004/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2218703004/diff/1/src/heap/heap.h#newcode899
src/heap/heap.h:899: return max_old_generation_size_ <=
kMaxOldSpaceSizeMediumMemoryDevice;
This is an indirect encoding for low memory device.

We could set optimize_for_size in ResourceConstraints::ConfigureDefaults if we
are below the low limit.

[Hannes Payer (out of office), 2016-08-05 14:30:07]

https://codereview.chromium.org/2218703004/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2218703004/diff/1/src/heap/heap.h#newcode892
src/heap/heap.h:892: void SetOptimizeForLatency() { optimize_for_memory_usage_ =
false; }
How about removing optimize_for_memory_usage_ and setting the tab mode on the
isolate? ShouldOptimizeForMemoryUsage could query the isolate for the mode. Then
the flag would have a more direct meaning and relate better with its setters.

[Hannes Payer (out of office), 2016-08-05 15:25:55]

lgtm

[ulan, 2016-08-05 15:29:37]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2016-08-05 15:29:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 15:33:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 15:33:14]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/10442)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[ulan, 2016-08-06 07:48:28]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-08-06 07:48:28]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2218703004/#ps40001
(title: "fix CE")

[commit-bot: I haz the power, 2016-08-06 07:48:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 08:30:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 08:30:27]

Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/10467)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/10411)
  v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)

[ulan_google, 2016-08-06 12:58:45]

The CQ bit was checked by ulan@google.com

[ulan_google, 2016-08-06 12:58:47]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2218703004/#ps60001
(title: "skip memory pressure test when --optimize-for-size is on")

[commit-bot: I haz the power, 2016-08-06 12:58:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 13:01:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 13:01:08]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/10468)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/10456)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/6465)
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/11988)

[ulan_google, 2016-08-07 15:12:49]

The CQ bit was checked by ulan@google.com

[ulan_google, 2016-08-07 15:12:50]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2218703004/#ps80001
(title: "x")

[commit-bot: I haz the power, 2016-08-07 15:13:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-07 15:33:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-07 15:36:22]

Description was changed from

==========
Unify memory optimization modes and flags.

This patch folds --optimize-for-size flag and check for low-memory device
into Heap::ShouldOptimizeForMemoryUsage() predicate.

It has the following side effects:
- the heap growing factor for low-memory devices is capped at 1.3 (old value was
2.0).
- the memory reducer will be more aggressive for low-memory devices.

BUG=chromium:634900
==========

to

==========
Unify memory optimization modes and flags.

This patch folds --optimize-for-size flag and check for low-memory device
into Heap::ShouldOptimizeForMemoryUsage() predicate.

It has the following side effects:
- the heap growing factor for low-memory devices is capped at 1.3 (old value was
2.0).
- the memory reducer will be more aggressive for low-memory devices.

BUG=chromium:634900

Committed: https://crrev.com/6cebf7d963c18e2ab09f2320c949baf0a4bed721
Cr-Commit-Position: refs/heads/master@{#38406}
==========

[commit-bot: I haz the power, 2016-08-07 15:36:23]

Patchset 5 (id:??) landed as
https://crrev.com/6cebf7d963c18e2ab09f2320c949baf0a4bed721
Cr-Commit-Position: refs/heads/master@{#38406}