third_party/WebKit/Source/core/layout/LayoutView.cpp - Issue 2218703002: [mapToVisualRectInAncestorSpace] Check for detached iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2218703002: [mapToVisualRectInAncestorSpace] Check for detached iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp » ('j') | third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutView.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutView.cpp b/third_party/WebKit/Source/core/layout/LayoutView.cpp

index a1f5a977f9e3d31fe10640850ec1b03bf95a1455..f42cfed39a8535ededb414b25fbfd431a66283ab 100644

--- a/third_party/WebKit/Source/core/layout/LayoutView.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutView.cpp

@@ -477,9 +477,12 @@ bool LayoutView::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ance

// Adjust for frame border.

rect.move(obj->contentBoxOffset());

return obj->mapToVisualRectInAncestorSpace(ancestor, rect, visualRectFlags);

+ return true;

}

- return true;

+ // This can happen, e.g., if the iframe element has display:none.

+ rect = LayoutRect();

+ return false;

}

void LayoutView::adjustOffsetForFixedPosition(LayoutRect& rect) const