Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2218663003: Fix TSAN suppressions for non-joinable ThreadTest. (Closed)

Created:
4 years, 4 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, gab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TSAN suppressions for non-joinable ThreadTest. The compiler does not include the class name in the symbol name for the TestBody method so the suppression added in r409915 doesn't work. This patch disables the test under TSan instead. BUG=634383, 629716 TBR=thestig@chromium.org NOTRY=true Committed: https://crrev.com/4ef71eefd26cd7c4f3ee5c7d4fbff9aaed2a5459 Cr-Commit-Position: refs/heads/master@{#410159}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M base/threading/thread_unittest.cc View 4 chunks +9 lines, -0 lines 1 comment Download
M build/sanitizers/tsan_suppressions.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218663003/1
4 years, 4 months ago (2016-08-05 20:48:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 20:56:10 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4ef71eefd26cd7c4f3ee5c7d4fbff9aaed2a5459 Cr-Commit-Position: refs/heads/master@{#410159}
4 years, 4 months ago (2016-08-05 20:58:52 UTC) #5
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-05 22:01:52 UTC) #6
gab
4 years, 4 months ago (2016-08-08 21:09:52 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/2218663003/diff/1/base/threading/thread_unitt...
File base/threading/thread_unittest.cc (right):

https://codereview.chromium.org/2218663003/diff/1/base/threading/thread_unitt...
base/threading/thread_unittest.cc:299: LOG(ERROR) << __FUNCTION__;
Leftover debug code?

Powered by Google App Engine
This is Rietveld 408576698