Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2218643002: [MD settings] show sites in the all-sites page (Closed)

Created:
4 years, 4 months ago by dschuyler
Modified:
4 years, 4 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] show sites in the all-sites page This CL enables the list of sites in the All sites page. BUG=634544 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/66c48375d541e6271fa13f0ac60ef1741099bb99 Cr-Commit-Position: refs/heads/master@{#409968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/site_settings/all_sites.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
dschuyler
So elsewhere in the code it was keying on the string 'all-sites' and not the ...
4 years, 4 months ago (2016-08-04 23:40:45 UTC) #5
tommycli
lgtm
4 years, 4 months ago (2016-08-04 23:49:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218643002/1
4 years, 4 months ago (2016-08-05 01:35:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 02:06:48 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 02:08:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66c48375d541e6271fa13f0ac60ef1741099bb99
Cr-Commit-Position: refs/heads/master@{#409968}

Powered by Google App Engine
This is Rietveld 408576698