Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Issue 2218633002: Remove unnecessary casting in CPVT_GenerateAP. (Closed)

Created:
4 years, 4 months ago by jaepark
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com, dsinclair
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unnecessary casting in CPVT_GenerateAP. Since CFX_BinaryBuf::GetBuffer() returns uint8_t*, casting to uint8_t* is unnecessary. Committed: https://pdfium.googlesource.com/pdfium/+/52a5005c453a9e08384e375ae51c5f1ad628fe86

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M core/fpdfdoc/cpvt_generateap.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
jaepark
4 years, 4 months ago (2016-08-04 23:15:08 UTC) #6
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-04 23:17:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218633002/1
4 years, 4 months ago (2016-08-04 23:22:12 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 23:22:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/52a5005c453a9e08384e375ae51c5f1ad628...

Powered by Google App Engine
This is Rietveld 408576698