content/renderer/media/media_stream_dependency_factory.cc - Issue 221863003: Notify the track before source provider goes away.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_dependency_factory.cc

Issue 221863003: Notify the track before source provider goes away. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: fixed the comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/media_stream_dependency_factory.cc

diff --git a/content/renderer/media/media_stream_dependency_factory.cc b/content/renderer/media/media_stream_dependency_factory.cc

index 1a829c3850ae51e95c6233aef817f361520651e9..0393fa4af2a6d133e55a615c8c535b2ee40de197 100644

--- a/content/renderer/media/media_stream_dependency_factory.cc

+++ b/content/renderer/media/media_stream_dependency_factory.cc

@@ -567,11 +567,8 @@ void MediaStreamDependencyFactory::CreateLocalAudioTrack(

StartLocalAudioTrack(audio_track.get());

- // Pass the pointer of the source provider to the blink audio track.

- blink::WebMediaStreamTrack writable_track = track;

- writable_track.setSourceProvider(audio_track->audio_source_provider());

// Pass the ownership of the native local audio track to the blink track.

+ blink::WebMediaStreamTrack writable_track = track;

writable_track.setExtraData(audio_track.release());

}