Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 221863002: Create resizer for allocation perspective split view (Closed)

Created:
6 years, 8 months ago by yurys
Modified:
6 years, 8 months ago
Reviewers:
alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Create resizer for allocation perspective split view Now there is a resizer between Allocations data grid and live objects summary view. The resizer has the same look as the one in the summary perspective. BUG=277984 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M Source/devtools/front_end/HeapSnapshotView.js View 2 chunks +9 lines, -1 line 0 comments Download
M Source/devtools/front_end/heapProfiler.css View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
yurys
6 years, 8 months ago (2014-04-02 07:42:23 UTC) #1
loislo
lgtm
6 years, 8 months ago (2014-04-02 07:46:43 UTC) #2
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 8 months ago (2014-04-02 07:47:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/221863002/1
6 years, 8 months ago (2014-04-02 07:47:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 08:58:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-02 08:58:15 UTC) #6
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 8 months ago (2014-04-02 09:14:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/221863002/1
6 years, 8 months ago (2014-04-02 09:14:25 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 10:25:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-02 10:25:41 UTC) #10
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 8 months ago (2014-04-02 15:08:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/221863002/1
6 years, 8 months ago (2014-04-02 15:08:40 UTC) #12
yurys
6 years, 8 months ago (2014-04-02 15:12:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 manually as r170659 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698