Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2218623003: Remove |ContentViewCore.getViewAndroidDelegate()| (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 3c6b6785be1127a753dab3a304db72121058af81..ec613ea349f678a3136d0c25b83da3892a9e7f5f 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -544,26 +544,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen
if (mNativeContentViewCore != 0) nativeWasResized(mNativeContentViewCore);
}
- /**
- * Returns a delegate that can be used to add and remove views from the current
- * container view. Clients can safely hold to instances of this class as it handles the
- * replacement of container views transparently.
- *
- * NOTE: Use with care, as not all ContentViewCore users setup their container view in the same
- * way. In particular, the Android WebView has limitations on what implementation details can
- * be provided via a child view, as they are visible in the API and could introduce
- * compatibility breaks with existing applications. If in doubt, contact the
- * android_webview/OWNERS
- *
- * @return A ViewAndroidDelegate that can be used to add and remove views.
- */
- @VisibleForTesting
- public ViewAndroidDelegate getViewAndroidDelegate() {
- // TODO(jinsukkim): Remove this method since it is only used by tests that don't
- // necessarily require the delegate.
- return mViewAndroidDelegate;
- }
-
@VisibleForTesting
public void setImeAdapterForTest(ImeAdapter imeAdapter) {
mImeAdapter = imeAdapter;

Powered by Google App Engine
This is Rietveld 408576698