Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1565)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2218603003: Timeline: show white overlay till page being reloaded paints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: No message, just blanket Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
index 087fe335b8344806be73f37c313371bab207c1e4..c06af84990cd9e8ea8fd207a79112542cd5034eb 100644
--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
@@ -323,8 +323,9 @@ WebDevToolsAgentImpl::WebDevToolsAgentImpl(
, m_networkAgent(nullptr)
, m_layerTreeAgent(nullptr)
, m_tracingAgent(nullptr)
- , m_includeViewAgents(includeViewAgents)
, m_layerTreeId(0)
+ , m_includeViewAgents(includeViewAgents)
+ , m_tracingActive(false)
{
DCHECK(isMainThread());
DCHECK(m_webLocalFrameImpl->frame());
@@ -521,6 +522,12 @@ void WebDevToolsAgentImpl::didRemovePageOverlay(const GraphicsLayer* layer)
m_layerTreeAgent->didRemovePageOverlay(layer);
}
+void WebDevToolsAgentImpl::rootLayerCleared()
+{
+ if (m_overlay)
+ m_overlay->maybeClearReloadingBlanket();
+}
+
void WebDevToolsAgentImpl::layerTreeViewChanged(WebLayerTreeView* layerTreeView)
{
m_layerTreeId = layerTreeView ? layerTreeView->layerTreeId() : 0;
@@ -532,12 +539,20 @@ void WebDevToolsAgentImpl::enableTracing(const String& categoryFilter)
{
if (m_client)
m_client->enableTracing(categoryFilter);
+ m_tracingActive = true;
}
void WebDevToolsAgentImpl::disableTracing()
{
if (m_client)
m_client->disableTracing();
+ m_tracingActive = false;
+}
+
+void WebDevToolsAgentImpl::willReloadPage()
+{
+ if (m_overlay && m_tracingActive)
+ m_overlay->showReloadingBlanket();
}
void WebDevToolsAgentImpl::setCPUThrottlingRate(double rate)

Powered by Google App Engine
This is Rietveld 408576698