Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.h

Issue 2218603003: Timeline: show white overlay till page being reloaded paints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/InspectorOverlay.h
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.h b/third_party/WebKit/Source/web/InspectorOverlay.h
index 720a88cfc225d28cd8b4cabd721e7748eb169580..0d610924c1d6213aeba41360e4ae6c7a1bff7889 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.h
+++ b/third_party/WebKit/Source/web/InspectorOverlay.h
@@ -83,6 +83,8 @@ public:
bool handleInputEvent(const WebInputEvent&);
void pageLayoutInvalidated(bool resized);
void setShowViewportSizeOnResize(bool);
+ void setReloadingBanner(const String&);
+ void maybeClearReloadingBanner();
void setPausedInDebuggerMessage(const String&);
// Does not yet include paint.
@@ -92,6 +94,11 @@ public:
String evaluateInOverlayForTest(const String&);
private:
+ enum class MessageType {
dgozman 2016/08/08 16:28:00 Can we have a single message?
+ Empty,
+ Reloading,
+ PausedInDebugger
+ };
explicit InspectorOverlay(WebViewImpl*);
class InspectorOverlayChromeClient;
class InspectorPageOverlayDelegate;
@@ -117,7 +124,7 @@ private:
bool isEmpty();
void drawNodeHighlight();
void drawQuadHighlight();
- void drawPausedInDebuggerMessage();
+ void drawMessages();
void drawViewSize();
float windowToViewportScale() const;
@@ -142,7 +149,8 @@ private:
void initializeLayoutEditorIfNeeded(Node*);
WebViewImpl* m_webViewImpl;
- String m_pausedInDebuggerMessage;
+ String m_message;
+ MessageType m_messageType;
Member<Node> m_highlightNode;
Member<Node> m_eventTargetNode;
InspectorHighlightConfig m_nodeHighlightConfig;

Powered by Google App Engine
This is Rietveld 408576698