chrome/browser/page_load_metrics/page_load_metrics_observer.cc - Issue 2218583002: [page_load_metrics] Log cache warmth ratios at parse stop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2218583002: [page_load_metrics] Log cache warmth ratios at parse stop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: thestig@ review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_observer.h ('k') | chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc

index 56df7682f4ef972f5143b189ebd4f945f3afd899..2fa1895367b6c9cc9dfd20da435a2b09a158227c 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc

@@ -14,6 +14,8 @@ PageLoadExtraInfo::PageLoadExtraInfo(

const base::Optional<base::TimeDelta>& time_to_commit,

UserAbortType abort_type,

const base::Optional<base::TimeDelta>& time_to_abort,

+ int num_cache_requests,

+ int num_network_requests,

const PageLoadMetadata& metadata)

: first_background_time(first_background_time),

first_foreground_time(first_foreground_time),

@@ -22,6 +24,8 @@ PageLoadExtraInfo::PageLoadExtraInfo(

time_to_commit(time_to_commit),

abort_type(abort_type),

time_to_abort(time_to_abort),

+ num_cache_requests(num_cache_requests),

+ num_network_requests(num_network_requests),

metadata(metadata) {}

PageLoadExtraInfo::PageLoadExtraInfo(const PageLoadExtraInfo& other) = default;