Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4919)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2218583002: [page_load_metrics] Log cache warmth ratios at parse stop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: thestig@ review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index cc5c8d92380d1f58fa9c2d70d24b47ecb053dcc5..7915a4d700a0a0b91ab9e882213c629d8156a436 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -168,6 +168,13 @@ const char kHistogramFailedProvisionalLoad[] =
const char kHistogramForegroundToFirstPaint[] =
"PageLoad.PaintTiming.ForegroundToFirstPaint";
+const char kHistogramCacheRequestPercentParseStop[] =
+ "PageLoad.Experimental.Cache.RequestPercent.ParseStop";
+const char kHistogramCacheTotalRequestsParseStop[] =
+ "PageLoad.Experimental.Cache.TotalRequests.ParseStop";
+const char kHistogramTotalRequestsParseStop[] =
+ "PageLoad.Experimental.TotalRequests.ParseStop";
+
const char kRapporMetricsNameCoarseTiming[] =
"PageLoad.CoarseTiming.NavigationToFirstContentfulPaint";
@@ -389,6 +396,18 @@ void CorePageLoadMetricsObserver::OnParseStop(
internal::kHistogramParseBlockedOnScriptLoadDocumentWrite,
timing.parse_blocked_on_script_load_from_document_write_duration
.value());
+
+ int total_requests = info.num_cache_requests + info.num_network_requests;
+ if (total_requests) {
+ UMA_HISTOGRAM_PERCENTAGE(
+ internal::kHistogramCacheRequestPercentParseStop,
+ (100 * info.num_cache_requests) / total_requests);
+ UMA_HISTOGRAM_COUNTS(internal::kHistogramCacheTotalRequestsParseStop,
+ info.num_cache_requests);
+ UMA_HISTOGRAM_COUNTS(internal::kHistogramTotalRequestsParseStop,
+ info.num_cache_requests + info.num_network_requests);
+ }
+
} else {
PAGE_LOAD_HISTOGRAM(internal::kBackgroundHistogramParseDuration,
parse_duration);

Powered by Google App Engine
This is Rietveld 408576698