Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2218563002: [promise] separate PerformPromiseThen from PromiseThen (Closed)

Created:
4 years, 4 months ago by Dan Ehrenberg
Modified:
4 years, 4 months ago
Reviewers:
caitp, adamk, Yang, gsathya
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promise] separate PerformPromiseThen from PromiseThen The `PerformPromiseThen` spec-internal operation is used by the async functions proposal, in order to ensure that AwaitExpressions are not observable via usual mechanisms/hooks, such as Symbol.species. This patch has a small optimization over the specification's language to short- circuit new Promise creation when unnecessary, similar to the logic in Promise.resolve. BUG=v8:5253 R=caitp@igalia.com, adamk@chromium.org, gsathya@chromium.org, yangguo@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -35 lines) Patch
M src/js/harmony-async-await.js View 1 chunk +29 lines, -14 lines 0 comments Download
M src/js/prologue.js View 2 chunks +4 lines, -0 lines 0 comments Download
M src/js/promise.js View 3 chunks +34 lines, -21 lines 0 comments Download
A test/mjsunit/harmony/async-await-species.js View 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
Dan Ehrenberg
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-04 20:37:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218563002/1
4 years, 4 months ago (2016-08-04 20:37:44 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-04 21:03:52 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 21:03:52 UTC) #4
Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/11888)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

Powered by Google App Engine
This is Rietveld 408576698