third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.cpp - Issue 2218533002: Backporting JSONValues from protocol::Values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.cpp

Issue 2218533002: Backporting JSONValues from protocol::Values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clone LoggingCanvas log Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/crypto/SubtleCrypto.cpp ('k') | third_party/WebKit/Source/modules/nfc/NFC.cpp » ('j') | third_party/WebKit/Source/platform/JSONValues.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.cpp

diff --git a/third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.cpp b/third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.cpp

index 7b6a271f65ad03cb7beec6cfcab3cba56b024677..b875cef17d779aa5402a556c176b85b2d154bf3c 100644

--- a/third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.cpp

+++ b/third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.cpp

@@ -21,12 +21,12 @@ DOMFileSystem* DevToolsHostFileSystem::isolatedFileSystem(DevToolsHost& host, co

void DevToolsHostFileSystem::upgradeDraggedFileSystemPermissions(DevToolsHost& host, DOMFileSystem* domFileSystem)

{

- RefPtr<JSONObject> message = JSONObject::create();

- message->setNumber("id", 0);

+ std::unique_ptr<JSONObject> message = JSONObject::create();

+ message->setInteger("id", 0);

message->setString("method", "upgradeDraggedFileSystemPermissions");

- RefPtr<JSONArray> params = JSONArray::create();

- message->setArray("params", params);

+ std::unique_ptr<JSONArray> params = JSONArray::create();

params->pushString(domFileSystem->rootURL().getString());

+ message->setArray("params", std::move(params));

host.sendMessageToEmbedder(message->toJSONString());

}