Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 221853003: Password bubble: Add a test for displayed password length. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h" 5 #include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"
6 6
7 #include "chrome/browser/chrome_notification_types.h" 7 #include "chrome/browser/chrome_notification_types.h"
8 #include "chrome/browser/ui/browser.h" 8 #include "chrome/browser/ui/browser.h"
9 #include "chrome/browser/ui/browser_finder.h" 9 #include "chrome/browser/ui/browser_finder.h"
10 #include "chrome/browser/ui/browser_window.h" 10 #include "chrome/browser/ui/browser_window.h"
(...skipping 22 matching lines...) Expand all
33 const int kMaxDisplayableStringWidth = 22; 33 const int kMaxDisplayableStringWidth = 22;
34 34
35 // Returns the width of |password_form|'s |type| field, clamped to the maximum 35 // Returns the width of |password_form|'s |type| field, clamped to the maximum
36 // displayable string width. 36 // displayable string width.
37 int GetFieldWidth(const autofill::PasswordForm& password_form, 37 int GetFieldWidth(const autofill::PasswordForm& password_form,
38 ManagePasswordsBubbleView::FieldType type) { 38 ManagePasswordsBubbleView::FieldType type) {
39 const gfx::FontList font_list; 39 const gfx::FontList font_list;
40 base::string16 display_string( 40 base::string16 display_string(
41 type == ManagePasswordsBubbleView::USERNAME_FIELD 41 type == ManagePasswordsBubbleView::USERNAME_FIELD
42 ? password_form.username_value 42 ? password_form.username_value
43 : ManagePasswordItemView::GetPasswordDisplayString( 43 : ManagePasswordsBubbleModel::GetPasswordDisplayString(
44 password_form.password_value)); 44 password_form.password_value));
45 return std::min( 45 return std::min(
46 gfx::FontList().GetExpectedTextWidth(kMaxDisplayableStringWidth), 46 gfx::FontList().GetExpectedTextWidth(kMaxDisplayableStringWidth),
47 gfx::GetStringWidth(display_string, font_list)); 47 gfx::GetStringWidth(display_string, font_list));
48 } 48 }
49 49
50 } // namespace 50 } // namespace
51 51
52 52
53 // ManagePasswordsBubbleView -------------------------------------------------- 53 // ManagePasswordsBubbleView --------------------------------------------------
(...skipping 304 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 manage_passwords_bubble_model_->manage_passwords_bubble_state() == 358 manage_passwords_bubble_model_->manage_passwords_bubble_state() ==
359 ManagePasswordsBubbleModel::PASSWORD_TO_BE_SAVED); 359 ManagePasswordsBubbleModel::PASSWORD_TO_BE_SAVED);
360 Close(); 360 Close();
361 } 361 }
362 362
363 void ManagePasswordsBubbleView::LinkClicked(views::Link* source, 363 void ManagePasswordsBubbleView::LinkClicked(views::Link* source,
364 int event_flags) { 364 int event_flags) {
365 DCHECK_EQ(source, manage_link_); 365 DCHECK_EQ(source, manage_link_);
366 manage_passwords_bubble_model_->OnManageLinkClicked(); 366 manage_passwords_bubble_model_->OnManageLinkClicked();
367 } 367 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698