Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 221853002: drive: Stop using GData WAPI formatted JSON file in file_system_apitest_chromeos.cc (Closed)

Created:
6 years, 8 months ago by hashimoto
Modified:
6 years, 8 months ago
Reviewers:
benwells, kinaba
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, kinuko+watch, extensions-reviews_chromium.org, nhiroki, tzik
Visibility:
Public.

Description

drive: Stop using GData WAPI formatted JSON file in file_system_apitest_chromeos.cc Loading empty_feed.json is meaningless now. LoadAccountMetadataForWapi() is deprecated and has no effect essentially. BUG=334544 TEST=browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
hashimoto
This change depends on https://codereview.chromium.org/221773002/ ("Deprecate FakeDriveService::LoadAccountMetadataForWapi")
6 years, 8 months ago (2014-04-02 07:40:53 UTC) #1
kinaba
lgtm
6 years, 8 months ago (2014-04-02 07:41:33 UTC) #2
hashimoto
benwells@, could you take a look at this change as an owner?
6 years, 8 months ago (2014-04-02 07:42:06 UTC) #3
benwells
lgtm
6 years, 8 months ago (2014-04-02 08:20:01 UTC) #4
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-04-03 11:58:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/221853002/1
6 years, 8 months ago (2014-04-03 11:58:35 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 12:43:43 UTC) #7
commit-bot: I haz the power
Retried try job too often on ios_rel_device_ninja for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device_ninja&number=9495
6 years, 8 months ago (2014-04-03 12:43:43 UTC) #8
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-04-03 15:12:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/221853002/1
6 years, 8 months ago (2014-04-03 15:13:17 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 15:37:11 UTC) #11
Message was sent while issue was closed.
Change committed as 261414

Powered by Google App Engine
This is Rietveld 408576698