Add browser test to the sharing dialog feature in Files.app.

chrome/browser/resources/file_manager/js/share_client.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @param {WebView} webView Web View tag.
  * @param {string} url Share Url for an entry.
  * @param {ShareClient.Observer} observer Observer instance.
@@ skipping 59 matching lines @@
  */
 ShareClient.Observer.prototype.onClosed = function() {
 };
 
 /**
  * Handles messages from the embedded dialog.
  * @param {Event} e Message event.
  * @private
  */
 ShareClient.prototype.onMessage_ = function(e) {
-  if (e.origin != ShareClient.SHARE_TARGET)
+  if (e.origin != ShareClient.SHARE_TARGET && !window.IN_TEST)

[yoshiki, 2013/08/05 16:19:38]

How about creating utility functions to return the target origin and to check
the source origin? I think spreading "window.IN_TEST" makes the code hard to
read, and may let us forget to add IN_TEST when adding code in feature.

[mtomasz, 2013/08/05 16:33:36]

The origin can change for each test, since the test server may start on
different ports, so we can't easily put the testing origin in a constant.
Pushing it from C++ to Javascript would be tricky. I was thinking about it, but
for simplicity I decided just to allow any origin when in tests.

Window.IN_TEST is always true when running Files.app within a test. We don't
have to worry about adding it. It is always set to true once the testing
extension connects to Files.app. Without it, we would have to manually let the
share client know to accept different share target than normally. I think it
will just add lots of unnecessary complexity.

We could add a utility function like. util.IsInTest() to make the code cleaner.
WDYT?

     return;
+
   var data = JSON.parse(e.data);
   switch (data.type) {
     case 'resize':
       this.observer_.onResized(data.args.width,
                                data.args.height,
                                this.postMessage_.bind(this, 'resizeComplete'));
       break;
     case 'prepareForVisible':
       this.postMessage_('prepareComplete');
       if (!this.loaded_) {
@@ skipping 32 matching lines @@
  * @param {string} type Message type.
  * @param {Object=} opt_args Optional arguments.
  * @private
  */
 ShareClient.prototype.postMessage_ = function(type, opt_args) {
   var message = {
     type: type,
     args: opt_args
   };
   this.webView_.contentWindow.postMessage(
-      JSON.stringify(message), ShareClient.SHARE_TARGET);
+      JSON.stringify(message),
+      !window.IN_TEST ? ShareClient.SHARE_TARGET : '*');
 };
 
 /**
  * Loads the embedded dialog. Can be called only one.
  */
 ShareClient.prototype.load = function() {
   if (this.loading_ || this.loaded_)
     throw new Error('Already loaded.');
   this.loading_ = true;
 
@@ skipping 13 matching lines @@
       'loadabort', this.onLoadAbortBound_);
   this.webView_.stop();
 };
 
 /**
  * Cleans the dialog by removing all handlers.
  */
 ShareClient.prototype.dispose = function() {
   this.abort();
 };