Clean up fx_ge_linux.cpp a little.

Clean up fx_ge_linux.cpp a little.

Committed: https://pdfium.googlesource.com/pdfium/+/611597203cc5fda87717fcd350b9b5932320e3c0

[Lei Zhang, 2016-08-04 17:12:35]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 17:12:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-08-04 17:13:49]

thestig@chromium.org changed reviewers:
+ npm@chromium.org

[commit-bot: I haz the power, 2016-08-04 17:26:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 17:26:02]

Dry run: This issue passed the CQ dry run.

[npm_g, 2016-08-04 17:53:16]

npm@google.com changed reviewers:
+ npm@google.com

[npm_g, 2016-08-04 17:53:16]

lgtm only one comment

https://codereview.chromium.org/2218433002/diff/1/core/fxge/ge/fx_ge_linux.cpp
File core/fxge/ge/fx_ge_linux.cpp (right):

https://codereview.chromium.org/2218433002/diff/1/core/fxge/ge/fx_ge_linux.cp...
core/fxge/ge/fx_ge_linux.cpp:101: ASSERT(index <
FX_ArraySize(g_LinuxGpFontList));
Maybe also include the condition index >= 0

[Lei Zhang, 2016-08-04 17:59:26]

https://codereview.chromium.org/2218433002/diff/1/core/fxge/ge/fx_ge_linux.cpp
File core/fxge/ge/fx_ge_linux.cpp (right):

https://codereview.chromium.org/2218433002/diff/1/core/fxge/ge/fx_ge_linux.cp...
core/fxge/ge/fx_ge_linux.cpp:101: ASSERT(index <
FX_ArraySize(g_LinuxGpFontList));
On 2016/08/04 17:53:16, npm_g wrote:
> Maybe also include the condition index >= 0

size_t is unsigned, always >= 0.

[Lei Zhang, 2016-08-04 17:59:41]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-08-04 17:59:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 17:59:58]

Description was changed from

==========
Clean up fx_ge_linux.cpp a little.
==========

to

==========
Clean up fx_ge_linux.cpp a little.

Committed:
https://pdfium.googlesource.com/pdfium/+/611597203cc5fda87717fcd350b9b5932320...
==========

[commit-bot: I haz the power, 2016-08-04 17:59:59]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/611597203cc5fda87717fcd350b9b5932320...

[Tom Sepez, 2016-08-04 19:20:17]

tsepez@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-08-04 19:20:18]

https://codereview.chromium.org/2218433002/diff/1/core/fxge/ge/fx_ge_linux.cpp
File core/fxge/ge/fx_ge_linux.cpp (right):

https://codereview.chromium.org/2218433002/diff/1/core/fxge/ge/fx_ge_linux.cp...
core/fxge/ge/fx_ge_linux.cpp:35: const FX_CHAR* NameArr[kLinuxGpNameSize];
drive-by: wouldn't a 2D array of char* be simpler than an array of struct
containing an array of char* ??

[Lei Zhang, 2016-08-04 19:22:25]

https://codereview.chromium.org/2218433002/diff/1/core/fxge/ge/fx_ge_linux.cpp
File core/fxge/ge/fx_ge_linux.cpp (right):

https://codereview.chromium.org/2218433002/diff/1/core/fxge/ge/fx_ge_linux.cp...
core/fxge/ge/fx_ge_linux.cpp:35: const FX_CHAR* NameArr[kLinuxGpNameSize];
On 2016/08/04 19:20:18, Tom Sepez wrote:
> drive-by: wouldn't a 2D array of char* be simpler than an array of struct
> containing an array of char* ??

Probably. Who wants to send the next CL? :)