Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

Issue 2218413002: Calls ShortcutHelper::FinalizeLauncherIcon() on worker thread instead of on IO thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_builder_impl2_thread0 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
index a1e7c812cae7a626809b88d7c73452367374ae58..709b6ef595f9d95d8651a340c63cb7abd1ce7490 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
@@ -85,13 +85,14 @@ void AddToHomescreenDialogHelper::Destroy(JNIEnv* env,
delete this;
}
-SkBitmap AddToHomescreenDialogHelper::FinalizeLauncherIcon(
- const SkBitmap& bitmap,
- const GURL& url,
- bool* is_generated) {
- DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
-
- return ShortcutHelper::FinalizeLauncherIcon(bitmap, url, is_generated);
+SkBitmap AddToHomescreenDialogHelper::FinalizeLauncherIconInBackground(
+ const SkBitmap& bitmap,
+ const GURL& url,
+ bool* is_generated) {
+ DCHECK(content::BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
+
+ return ShortcutHelper::FinalizeLauncherIconInBackground(bitmap, url,
+ is_generated);
}
void AddToHomescreenDialogHelper::AddShortcut(
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698