components/offline_pages/background/request_queue_unittest.cc - Issue 2218403002: Change database scheme - add state and start tracking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_queue_unittest.cc

Issue 2218403002: Change database scheme - add state and start tracking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Stop clearing last request time Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/background/request_queue_store_unittest.cc ('k') | components/offline_pages/background/save_page_request.h » ('j') | components/offline_pages/background/save_page_request.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_queue_unittest.cc

diff --git a/components/offline_pages/background/request_queue_unittest.cc b/components/offline_pages/background/request_queue_unittest.cc

index cba4f10082ccc2b8b15db89b5db305e16dd0f59a..967257c6d83c047573e7cac7a124d32bf3fc7125 100644

--- a/components/offline_pages/background/request_queue_unittest.cc

+++ b/components/offline_pages/background/request_queue_unittest.cc

@@ -259,7 +259,7 @@ TEST_F(RequestQueueTest, UpdateRequest) {

PumpLoop();

// Update the request, ensure it succeeded.

- request.set_attempt_count(kRetryCount);

+ request.set_completed_attempt_count(kRetryCount);

queue()->UpdateRequest(

request,

base::Bind(&RequestQueueTest::UpdateRequestDone, base::Unretained(this)));

@@ -272,7 +272,7 @@ TEST_F(RequestQueueTest, UpdateRequest) {

PumpLoop();

ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());

ASSERT_EQ(1ul, last_requests().size());

- ASSERT_EQ(kRetryCount, last_requests().front().attempt_count());

+ ASSERT_EQ(kRetryCount, last_requests().front().completed_attempt_count());

}

TEST_F(RequestQueueTest, UpdateRequestNotPresent) {