Change database scheme - add state and start tracking

components/offline_pages/background/offliner_policy.h

Index: components/offline_pages/background/offliner_policy.h
diff --git a/components/offline_pages/background/offliner_policy.h b/components/offline_pages/background/offliner_policy.h
index 5a6591aec46621559a02c1d8e5fbbe9dba42a865..1180c08da5ace4028725aa0150d3be4085400715 100644
--- a/components/offline_pages/background/offliner_policy.h
+++ b/components/offline_pages/background/offliner_policy.h
@@ -6,7 +6,8 @@
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_POLICY_H_
 
 namespace {
-const int kMaxTries = 1;
+const int kMaxStartedTries = 5;
+const int kMaxCompletedTries = 1;
 const int kBackgroundProcessingTimeBudgetSeconds = 170;
 const int kSinglePageTimeLimitSeconds = 120;
 const int kMinimumBatteryPercentageForNonUserRequestOfflining = 50;
@@ -22,14 +23,21 @@ class OfflinerPolicy {
   OfflinerPolicy()
       : prefer_untried_requests_(false),
         prefer_earlier_requests_(true),
-        retry_count_is_more_important_than_recency_(false) {}
+        retry_count_is_more_important_than_recency_(false),
+        max_started_tries_(kMaxStartedTries),
+        max_completed_tries_(kMaxCompletedTries) {}
 
+  // Constructor for unit tests.
   OfflinerPolicy(bool prefer_untried,
                  bool prefer_earlier,
-                 bool prefer_retry_count)
+                 bool prefer_retry_count,
+                 int max_started_tries,
+                 int max_completed_tries)
       : prefer_untried_requests_(prefer_untried),
         prefer_earlier_requests_(prefer_earlier),
-        retry_count_is_more_important_than_recency_(prefer_retry_count) {}
+        retry_count_is_more_important_than_recency_(prefer_retry_count),
+        max_started_tries_(max_started_tries),
+        max_completed_tries_(max_completed_tries) {}
 
   // TODO(petewil): Numbers here are chosen arbitrarily, do the proper studies
   // to get good policy numbers.
@@ -48,8 +56,12 @@ class OfflinerPolicy {
     return retry_count_is_more_important_than_recency_;
   }
 
-  // The max number of times we will retry a request.
-  int GetMaxTries() const { return kMaxTries; }
+  // The max number of times we will *start* a request.

[fgorski, 2016/08/08 17:48:05]

Drop the **.

I think you could add something like:
Starting an attempt does not need it has to successfully finished. It could be
cause by the browser being evicted from memory, or in rare cases prerenderer
issues.

[Pete Williamson, 2016/08/08 18:44:28]

Done.

+  int GetMaxStartedTries() const { return max_started_tries_; }
+
+  // The max number of times we will retry a request when the attempt
+  // completed, but failed.
+  int GetMaxCompletedTries() const { return max_completed_tries_; }
 
   bool PowerRequiredForUserRequestedPage() const { return false; }
 
@@ -92,6 +104,8 @@ class OfflinerPolicy {
   bool prefer_untried_requests_;
   bool prefer_earlier_requests_;
   bool retry_count_is_more_important_than_recency_;
+  int max_started_tries_;
+  int max_completed_tries_;
 };
 }