Change database scheme - add state and start tracking

components/offline_pages/background/request_coordinator.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/background/request_coordinator.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 263 matching lines @@
     // TODO(dougarnett): See if we can conclusively identify other attempt
     // aborted cases to treat this way (eg, for Render Process Killed).
     SavePageRequest updated_request(request);
     updated_request.MarkAttemptAborted();
     queue_->UpdateRequest(updated_request,
                           base::Bind(&RequestCoordinator::UpdateRequestCallback,
                                      weak_ptr_factory_.GetWeakPtr(),
                                      updated_request.client_id()));
 
   } else if (status == Offliner::RequestStatus::SAVED ||
-             request.attempt_count() >= policy_->GetMaxTries()) {
+             request.completed_attempt_count() + 1 >=

[fgorski, 2016/08/08 17:48:05]

What is going on with the +1. Please explain it.

[Pete Williamson, 2016/08/08 18:44:28]

comment added.

+                 policy_->GetMaxCompletedTries()) {

[fgorski, 2016/08/08 17:48:05]

Do you plan to check for GetMaxStartedTries() here?

[Pete Williamson, 2016/08/08 18:44:28]

Checking GetMaxStartedTries is coming in a future changelist once this one
clears.  Also, this is not the right place to check it, we check it before
starting a request, not after.

     // Remove the request from the queue if it either succeeded or exceeded the
     // max number of retries.
     queue_->RemoveRequest(
         request.request_id(),
         base::Bind(&RequestCoordinator::UpdateRequestCallback,
                    weak_ptr_factory_.GetWeakPtr(), request.client_id()));
   } else {
     // If we failed, but are not over the limit, update the request in the
     // queue.
     SavePageRequest updated_request(request);
@@ skipping 37 matching lines @@
   return trigger_conditions;
 }
 
 void RequestCoordinator::GetOffliner() {
   if (!offliner_) {
     offliner_ = factory_->GetOffliner(policy_.get());
   }
 }
 
 }  // namespace offline_pages