GCP2.0 Device: Instant AccessToken update on AuthFailed.

cloud_print/gcp20/prototype/printer.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cloud_print/gcp20/prototype/printer.h"
 
 #include <stdio.h>
 #include <string>
 #include <vector>
 
@@ skipping 164 matching lines @@
 
 void Printer::Stop() {
   dns_server_.Shutdown();
   http_server_.Shutdown();
   requester_.reset();
   print_job_handler_.reset();
   xmpp_listener_.reset();
 }
 
 void Printer::OnAuthError() {
-  access_token_update_ = base::Time::Now();
-  ChangeState(OFFLINE);
-  // TODO(maksymb): Implement *instant* updating of access_token.
+  access_token_update_ = base::Time::UnixEpoch();
+  ReconnectIn(base::TimeDelta::FromSeconds(0));
 }
 
 std::string Printer::GetAccessToken() {
   return access_token_;
 }
 
 PrivetHttpServer::RegistrationErrorStatus Printer::RegistrationStart(
     const std::string& user) {
   PrivetHttpServer::RegistrationErrorStatus status = CheckCommonRegErrors(user);
   if (status != PrivetHttpServer::REG_ERROR_OK)
@@ skipping 551 matching lines @@
       return "connecting";
     case NOT_CONFIGURED:
       return "not-configured";
 
     default:
       NOTREACHED();
       return "";
   }
 }
 
+void Printer::ReconnectIn(const base::TimeDelta& delay) {
+  requester_.reset();
+  xmpp_listener_.reset();
+  base::MessageLoop::current()->PostDelayedTask(

[gene, 2013/08/05 20:56:28]

Since this is a post task, it is possible you can get /privet/register call
between OnAuthError() and TryConnect(). Since requester_ will be NULL, it will
crash in this case.

[maksymb, 2013/08/06 21:45:54]

Done.

[gene, 2013/08/08 02:01:55]

Could you please explain how this has been fixed?
What if you get /privet/printer/submitdoc between OnAuthError() and
TryConnect()?

[maksymb, 2013/08/08 18:35:46]

/privet/accesstoken can be processed only in OnIdle

+      FROM_HERE,
+      base::Bind(&Printer::TryConnect, AsWeakPtr()),
+      delay);
+}
+
 bool Printer::ChangeState(ConnectionState new_state) {
   if (connection_state_ == new_state)
     return false;
 
   connection_state_ = new_state;
   LOG(INFO) << base::StringPrintf(
       "Printer is now %s (%s)",
       ConnectionStateToString(connection_state_).c_str(),
       IsRegistered() ? "registered" : "unregistered");
 
   dns_server_.UpdateMetadata(CreateTxt());
 
-  switch (connection_state_) {
-    case CONNECTING:
-      break;
-
-    case ONLINE:
-      break;
-
-    case OFFLINE:
-      requester_.reset();
-      xmpp_listener_.reset();
-      base::MessageLoop::current()->PostDelayedTask(
-          FROM_HERE,
-          base::Bind(&Printer::TryConnect, AsWeakPtr()),
-          base::TimeDelta::FromSeconds(kReconnectTimeout));
-
-    case NOT_CONFIGURED:
-      break;
-
-    default:
-      NOTREACHED();
-  }
+  if (connection_state_ == OFFLINE)
+    ReconnectIn(base::TimeDelta::FromSeconds(kReconnectTimeout));
 
   return true;
 }