Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 22184006: Make LayerRectList's indexed getter consistent with other indexed getters (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, do-not-use, lgombos
Visibility:
Public.

Description

Make LayerRectList's indexed getter consistent with other indexed getters Make LayerRectList's indexed getter consistent with other indexed getters: - The argument is now mandatory - We no longer throw if the argument is negative (dropped [IsIndex]) This is an internal interface and it has not impact on the existing layout tests. This is one step towards completely removing [IsIndex] Blink-specific IDL extended attribute. R=haraken BUG=237739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155536

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/testing/LayerRectList.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-05 15:14:30 UTC) #1
haraken
LGTM. Just a change to testing/, so no harm on web.
7 years, 4 months ago (2013-08-05 15:27:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22184006/1
7 years, 4 months ago (2013-08-05 15:28:13 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-05 19:06:47 UTC) #4
Message was sent while issue was closed.
Change committed as 155536

Powered by Google App Engine
This is Rietveld 408576698