Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: content/browser/android/in_process/synchronous_compositor_output_surface.cc

Issue 221833009: cc: Move scheduling logic out of OutputSurface (Closed) Base URL: http://git.chromium.org/chromium/src.git@swapAck2Sched11
Patch Set: rebase; add comment about race Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/in_process/synchronous_compositor_output_surface.cc
diff --git a/content/browser/android/in_process/synchronous_compositor_output_surface.cc b/content/browser/android/in_process/synchronous_compositor_output_surface.cc
index edadb0e9fcf2471f5a3de3629d5bde8fac24eb38..de609c3c7eb1a80fef535c4a6482c75afd5eae46 100644
--- a/content/browser/android/in_process/synchronous_compositor_output_surface.cc
+++ b/content/browser/android/in_process/synchronous_compositor_output_surface.cc
@@ -69,6 +69,7 @@ SynchronousCompositorOutputSurface::SynchronousCompositorOutputSurface(
: cc::OutputSurface(
scoped_ptr<cc::SoftwareOutputDevice>(new SoftwareDevice(this))),
routing_id_(routing_id),
+ needs_begin_frame_(false),
invoking_composite_(false),
did_swap_buffer_(false),
current_sw_canvas_(NULL),
@@ -126,7 +127,6 @@ void SynchronousCompositorOutputSurface::Reshape(
void SynchronousCompositorOutputSurface::SetNeedsBeginFrame(bool enable) {
DCHECK(CalledOnValidThread());
needs_begin_frame_ = enable;
- client_ready_for_begin_frame_ = true;
SynchronousCompositorOutputSurfaceDelegate* delegate = GetDelegate();
if (delegate && !invoking_composite_)
delegate->SetContinuousInvalidate(needs_begin_frame_);
@@ -142,7 +142,7 @@ void SynchronousCompositorOutputSurface::SwapBuffers(
UpdateFrameMetaData(frame->metadata);
did_swap_buffer_ = true;
- DidSwapBuffers();
+ client_->DidSwapBuffers();
}
void SynchronousCompositorOutputSurface::UpdateFrameMetaData(
@@ -236,7 +236,7 @@ void SynchronousCompositorOutputSurface::InvokeComposite(
SetExternalDrawConstraints(
adjusted_transform, viewport, clip, valid_for_tile_management);
SetNeedsRedrawRect(gfx::Rect(viewport.size()));
- BeginFrame(cc::BeginFrameArgs::CreateForSynchronousCompositor());
+ client_->BeginFrame(cc::BeginFrameArgs::CreateForSynchronousCompositor());
// After software draws (which might move the viewport arbitrarily), restore
// the previous hardware viewport to allow CC's tile manager to prioritize
@@ -251,18 +251,13 @@ void SynchronousCompositorOutputSurface::InvokeComposite(
}
if (did_swap_buffer_)
- OnSwapBuffersComplete();
+ client_->DidSwapBuffersComplete();
SynchronousCompositorOutputSurfaceDelegate* delegate = GetDelegate();
if (delegate)
delegate->SetContinuousInvalidate(needs_begin_frame_);
}
-void SynchronousCompositorOutputSurface::PostCheckForRetroactiveBeginFrame() {
- // Synchronous compositor cannot perform retroactive BeginFrames, so
- // intentionally no-op here.
-}
-
void SynchronousCompositorOutputSurface::SetMemoryPolicy(
const SynchronousCompositorMemoryPolicy& policy) {
DCHECK(CalledOnValidThread());

Powered by Google App Engine
This is Rietveld 408576698