Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: cc/output/output_surface_client.h

Issue 221833009: cc: Move scheduling logic out of OutputSurface (Closed) Base URL: http://git.chromium.org/chromium/src.git@swapAck2Sched11
Patch Set: rebase; fix tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/output_surface_client.h
diff --git a/cc/output/output_surface_client.h b/cc/output/output_surface_client.h
index 08d9b624884ee74d73dc021ec16dc57774057aea..485a7ba40eba708d07081619db4962dcf7798903 100644
--- a/cc/output/output_surface_client.h
+++ b/cc/output/output_surface_client.h
@@ -30,8 +30,13 @@ class CC_EXPORT OutputSurfaceClient {
virtual bool DeferredInitialize(
scoped_refptr<ContextProvider> offscreen_context_provider) = 0;
virtual void ReleaseGL() = 0;
+ virtual void CommitVSyncParameters(base::TimeTicks timebase,
+ base::TimeDelta interval) = 0;
virtual void SetNeedsRedrawRect(const gfx::Rect& damage_rect) = 0;
virtual void BeginFrame(const BeginFrameArgs& args) = 0;
+ // DidSwapBuffers and OnSwapBuffersComplete should not be called
+ // when the OutputSurface is lost to avoid race conditions in the scheduler
+ // if OnSwapBuffersComplete arrives for the previous OutputSurface.
Sami 2014/04/08 13:46:01 It feels like this comment belongs to OutputSurfac
brianderson 2014/04/09 02:52:05 Sounds good.
brianderson 2014/04/10 23:45:58 Done.
virtual void DidSwapBuffers() = 0;
virtual void OnSwapBuffersComplete() = 0;
virtual void ReclaimResources(const CompositorFrameAck* ack) = 0;

Powered by Google App Engine
This is Rietveld 408576698