Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 221833004: Cleanup inspector test expectations (Closed)

Created:
6 years, 8 months ago by pfeldman
Modified:
6 years, 8 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Cleanup inspector test expectations BUG=344238, 257132, 280698, 308952, 333882, 339252, 313783, 352466, 351696 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170650

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -196 lines) Patch
M LayoutTests/TestExpectations View 10 chunks +0 lines, -21 lines 0 comments Download
M LayoutTests/http/tests/inspector/network/network-xhr-replay.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/inspector/network/network-xhr-replay-expected.txt View 1 chunk +60 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/inspector/websocket/websocket-handshake-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/multiple-imports-edit-crash.html View 4 chunks +2 lines, -9 lines 0 comments Download
M LayoutTests/inspector/elements/styles/multiple-imports-edit-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/profiler/canvas2d/canvas2d-api-changes-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-auto-record.html View 1 chunk +15 lines, -9 lines 1 comment Download
M LayoutTests/inspector/timeline/timeline-auto-record-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
D LayoutTests/platform/linux-x86/http/tests/inspector/network/network-xhr-replay-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/platform/linux/http/tests/inspector/network/network-xhr-replay-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/platform/mac/http/tests/inspector/network/network-xhr-replay-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/platform/win-xp/http/tests/inspector/network/network-xhr-replay-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/platform/win/http/tests/inspector/network/network-xhr-replay-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
apavlov
lgtm https://codereview.chromium.org/221833004/diff/1/LayoutTests/inspector/timeline/timeline-auto-record.html File LayoutTests/inspector/timeline/timeline-auto-record.html (right): https://codereview.chromium.org/221833004/diff/1/LayoutTests/inspector/timeline/timeline-auto-record.html#newcode24 LayoutTests/inspector/timeline/timeline-auto-record.html:24: InspectorTest.runWhenPageLoads(function() {}); InspectorTest.reloadPage() ?
6 years, 8 months ago (2014-04-02 11:32:33 UTC) #1
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 8 months ago (2014-04-02 11:34:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/221833004/1
6 years, 8 months ago (2014-04-02 11:34:37 UTC) #3
pfeldman
The CQ bit was unchecked by pfeldman@chromium.org
6 years, 8 months ago (2014-04-02 11:35:06 UTC) #4
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 8 months ago (2014-04-02 11:35:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/221833004/1
6 years, 8 months ago (2014-04-02 11:35:21 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 11:35:50 UTC) #7
Message was sent while issue was closed. 
Change committed as 170650

Powered by Google App Engine
This is Rietveld 408576698