Test for WebSocketJob being deleted on the stack

net/websockets/websocket_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/websockets/websocket_job.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/lazy_instance.h"
@@ skipping 286 matching lines @@
     spdy_websocket_stream_.reset();
   }
 
   CompleteIO(result);
 }
 
 void WebSocketJob::OnSentSpdyHeaders() {
   DCHECK_NE(INITIALIZED, state_);
   if (state_ != CONNECTING)
     return;
+  size_t original_length = handshake_request_->original_length();
+  handshake_request_.reset();
   if (delegate_)
-    delegate_->OnSentData(socket_.get(), handshake_request_->original_length());
-  handshake_request_.reset();
+    delegate_->OnSentData(socket_.get(), original_length);
 }
 
 void WebSocketJob::OnSpdyResponseHeadersUpdated(
     const SpdyHeaderBlock& response_headers) {
   DCHECK_NE(INITIALIZED, state_);
   if (state_ != CONNECTING)
     return;
   // TODO(toyoshim): Fallback to non-spdy connection?
   handshake_response_->ParseResponseHeaderBlock(response_headers,
                                                 challenge_,
@@ skipping 96 matching lines @@
 }
 
 void WebSocketJob::OnSentHandshakeRequest(
     SocketStream* socket, int amount_sent) {
   DCHECK_EQ(state_, CONNECTING);
   handshake_request_sent_ += amount_sent;
   DCHECK_LE(handshake_request_sent_, handshake_request_->raw_length());
   if (handshake_request_sent_ >= handshake_request_->raw_length()) {
     // handshake request has been sent.
     // notify original size of handshake request to delegate.
+    // Reset the handshake_request_ first in case this object is deleted by the
+    // delegate.
+    size_t original_length = handshake_request_->original_length();
+    handshake_request_.reset();
     if (delegate_)
-      delegate_->OnSentData(
-          socket,
-          handshake_request_->original_length());
-    handshake_request_.reset();
+      delegate_->OnSentData(socket, original_length);
   }
 }
 
 void WebSocketJob::OnReceivedHandshakeResponse(
     SocketStream* socket, const char* data, int len) {
   DCHECK_EQ(state_, CONNECTING);
   if (handshake_response_->HasResponse()) {
     // If we already has handshake response, received data should be frame
     // data, not handshake message.
     received_data_after_handshake_.insert(
@@ skipping 252 matching lines @@
 
   scoped_refptr<IOBufferWithSize> next_buffer = send_buffer_queue_.front();
   send_buffer_queue_.pop_front();
   current_send_buffer_ =
       new DrainableIOBuffer(next_buffer.get(), next_buffer->size());
   SendDataInternal(current_send_buffer_->data(),
                    current_send_buffer_->BytesRemaining());
 }
 
 }  // namespace net