Better CrOS logout button for vertical trays.

ui/views/controls/button/label_button.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_BUTTON_LABEL_BUTTON_H_
 #define UI_VIEWS_CONTROLS_BUTTON_LABEL_BUTTON_H_
 
 #include <memory>
 
 #include "base/compiler_specific.h"
@@ skipping 28 matching lines @@
   LabelButton(ButtonListener* listener, const base::string16& text);
   ~LabelButton() override;
 
   // Gets or sets the image shown for the specified button state.
   // GetImage returns the image for STATE_NORMAL if the state's image is empty.
   virtual gfx::ImageSkia GetImage(ButtonState for_state) const;
   void SetImage(ButtonState for_state, const gfx::ImageSkia& image);
 
   // Gets or sets the text shown on the button.
   const base::string16& GetText() const;
-  void SetText(const base::string16& text);
+  virtual void SetText(const base::string16& text);

[sadrul, 2016/08/08 20:25:08]

Can there a different virtual OnTextChanged() that Md- overrides instead?

[Evan Stade, 2016/08/08 22:40:54]

I just went and made this change, but then I realized that this was inconsistent
with SetEnabledTextColors() and AdjustFontSize() (as well as many other
functions like View::SetBorder and View::SetVisible). I don't feel strongly one
way or the other about which is better but I'd rather keep it consistent with
other setters in this class.

[sadrul, 2016/08/08 22:56:49]

OK

 
   // Sets the text color shown for the specified button |for_state| to |color|.
   void SetTextColor(ButtonState for_state, SkColor color);
 
   // Sets the text colors shown for the non-disabled states to |color|.
   virtual void SetEnabledTextColors(SkColor color);
 
   // Sets drop shadows underneath the text.
   void SetTextShadows(const gfx::ShadowValues& shadows);
 
@@ skipping 174 matching lines @@
   gfx::HorizontalAlignment horizontal_alignment_;
 
   std::unique_ptr<Painter> focus_painter_;
 
   DISALLOW_COPY_AND_ASSIGN(LabelButton);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_BUTTON_LABEL_BUTTON_H_